Comments (5)
You're right, the release won't be performed until after the read-only task returns unless specific conditions are met, such as the read-only task is using a different physical instance from the one the release operation will be copying dirty data to as part of the release. It's a standard WAR dependence. Since it looks like you didn't implement a custom mapper, it's unlikely that you're ensuring that they are going to different physical instances using the WAR flag. You need to prove to me that the read-only tasks are using a different physical instance from the one being targeted by the release before I'll look into this further.
from legion.
I have added a custom mapper for read_write test. The mapper enables WAR flag for both read_only and read_write tasks. The testcase always acquires the logical region before launching every read_only (or read_write) task, while those tasks require in-memory physical instances, so I would expect runtime could perform WAR optimizations for read_only and read_write tasks.
BTW, it seems Legion runtime still serializes all tasks, but I cannot debug this with legion_spy. The error message I got indicates that HLR didn't log physical region creation for attach operation.
from legion.
Two things to check:
- You are unmapping the 'attached' region before you do any of these task calls right? Otherwise the runtime is issuing inline unmap/remap calls around every task call which we definitely account for your serialization.
- In your custom mapper, you are actually mapping tasks to different processors?
Also, how do you know you are not getting parallel execution?
from legion.
I have updated the custom mapper in attach-file branch:
- Yes, I have unmapped the attached region before launching subtasks.
- In current mapper, all read_only and read_write tasks are mapped to different processors.
It seems legion_spy doesn't log physical instance creation for attach-file. I am using legion_prof to debug this right now. Following link shows an execution of read_write test. All tasks mapped to the first proc are read_only task, while all other tasks are mapped to the last proc.
http://stanford.edu/~zhihao/legion_prof.html
from legion.
The problem was that the leaf tasks in the 'read_write' test were not actually marked as a leaf task, which practically prevented WAR optimization from being applied. Closed by commit 8142726.
from legion.
Related Issues (20)
- Assertion min_depth <= depth failed HOT 26
- Regent: Leaks all predicates
- Try attach_file to improve IO performance, but did not get the desired effect HOT 16
- Legion spackage does not allow CUDA 12 HOT 14
- Deterministic error affecting HTR HOT 10
- Profiler: Need to create legion_prof directory scrubbed of all task/field names HOT 4
- CMake: FindGASNet.cmake doesn't accept ofi-slingshot11 HOT 5
- Warnings when compiling Legion with CUDA 12.1 HOT 17
- Realm: Add the dir containing libpython to BUILD_RPATH HOT 1
- Performance Improvement of Legion + MPI HOT 2
- Regent test failures on Apple M1/M2
- Assertion `sit->second == local_space` failed HOT 3
- S3D OOM HOT 28
- Realm tutorial: HIP missing 5-argument surf2Dwrite HOT 3
- Replicated Heap for the HIP module
- Implicit top-level tasks break Legion Prof HOT 28
- Regent: nondeterministic separate_compilation.rg crash in CI HOT 20
- How to Apply Realms to Clusters HOT 2
- How to support CPU multi-thread in a different way? HOT 2
- Does Legion support automatic task partation? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from legion.