Comments (4)
So just to be clear, we want it to be a failure for the mapper to specify any target processor that is not an actual processor? In this case, the mapper picked NO_PROC which is clearly wrong. However, I can also envision a case where the mapper picks a processor that used to exist but no longer does (due to a hard fault or something), and I'm not sure we want that to be a hard stop if the mapper makes that mistake. To summarize: we can either make it a hard failure, or we can figure out a way to hand the problem back to the mapper.
from legion.
The case for which I would like a more helpful (and fatal) error message is when a task is launched and the only available variants for that are for processor kinds that do not exist anywhere in the machine. This is a case where throwing it back to the mapper to decide again can't result in any other answer. That said, it seems like this information may only be available to the mapper and therefore should be an error check in the default mapper rather than in the HLR.
In cases where the mapper's chosen processor has vanished, or when the mapper knows how to create new variants of the task in question, I agree throwing it back to the mapper is preferable to a fatal error.
from legion.
Alright, adding this to the list of things to do when updating the mapping API.
from legion.
This has definitely been fixed by the new mapper API.
from legion.
Related Issues (20)
- I'd like to ask about multithreading. HOT 6
- legion_prof_rs: channel names getting cut off in archive viewer HOT 1
- Realm: compile time error in `shm.cc` HOT 4
- Legion: AllGatherCollective<false>::~AllGatherCollective() [INORDER = false]: Assertion `done_triggered' failed. HOT 5
- legion_prof_rs: multiple nodes merged in archive viewer HOT 3
- Realm: Signal handler not demangling C++ names on MacOS HOT 2
- Legion: Deserializer segfault HOT 5
- Legion: shardrefine slow startup on Summit HOT 6
- Realm: cuMemcpy3dAsync_v2 crash on Summit HOT 16
- Realm: set_bit id assertion on Summit HOT 3
- Realm: Failed to send message HOT 2
- [Question] Requesting profiling data on "implicit" region copy tasks HOT 10
- A question about Control Replication shards HOT 2
- HTR correctness failure at 1 node with GPUs HOT 16
- About Performance Issues Using Accessors HOT 13
- profiler: improve the error message for the rust profiler when parsing logs HOT 1
- profiler: record the git hash to the log files to avoid errors when using the wrong version of the profiler HOT 6
- How do I partition a 3D index space? HOT 6
- Legion_prof: `assertion failed: copy_inst_info._src.unwrap() == chan_src` HOT 13
- Realm: prometheus support HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from legion.