Comments (9)
bob-carpenter
commented on July 29, 2024
I think this could either be a standalone program or a mode for stanc. I'm inclined to have it be standalone, like the C++ linter from Google (written in Python). On the other hand, it'd mean another executable for the interfaces to deal with rather than an argument to an existing interface.
… On Dec 12, 2018, at 3:27 PM, Matthijs Vákár ***@***.***> wrote:
Implement a linter for Stan models to flag up common programming mistakes, e.g. using unvectorized distributions in a loop where a vectorized version is available. This would involve
• adding an extra command line argument for lint mode;
• writing the lint algorithm which walks the AST, similar to the semantic check, printing warnings and giving hints where there is reason to suspect a better programming style might be possible (to be contrasted with the semantic check, which rejects programs which would clearly throw run-time errors).
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
from stanc3.
VMatthijs
commented on July 29, 2024
Note that it would be reusing the lexer, parser and AST of the compiler. Also, standalone would give us an extra thing to distribute. So I think it would be more work to have it be standalone.
What's your thinking for wanting it to be standalone?
from stanc3.
bob-carpenter
commented on July 29, 2024
Only that all the other lint modes I know are standalone programs, not part of the actual compiler.
I don't object to building it into the parser if it's easier. I just want to make sure it can be run independently (that is, we don't want to be generating code and trying to compile it---we just want to provide lint errors in lint mode).
… On Dec 13, 2018, at 10:26 AM, Matthijs Vákár ***@***.***> wrote:
Note that it would be reusing the lexer, parser and AST of the compiler. Also, standalone would give us an extra thing to distribute. So I think it would be more work to have it be standalone.
What's your thinking for wanting it to be standalone?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
from stanc3.
VMatthijs
commented on July 29, 2024
Sure! The same is currently already true for the auto-formatter in stanc3. That would also not proceed to code generation. Would something similar work for the linter?
from stanc3.
bob-carpenter
commented on July 29, 2024
Yes. We'll have to think about how to call an executable that has many sub-executables. Are you imaginging something along the lines of the way git formulates commands, e.g.,
git commit -a -m "hi there"
where git invokes the executable and commit tells it which command to run, then the rest are arguments to the command?
from stanc3.
VMatthijs
commented on July 29, 2024
Currently, I was just using a bunch of command line options --<=optional-argument>, which can be combined in any way. I had imagined the behaviour that if you use the --lint or --auto-format options, it goes into linting or pretty-printing mode after semantic check, rather than code generation.
from stanc3.
bob-carpenter
commented on July 29, 2024
My only concern is that it's possible to check all the options and there is clear doc on all of their implicit assumptions and their interactions. So it looks like --lint and --auto-format turn off code generation, which is otherwise on by default?
I'd prefer the arguments to not interact with each other.
One possibility would be to have a --generate-cpp option that will control whether C++ is generated. Then at least these arguments would be independently specified, each turning off or on one form of output.
… On Dec 13, 2018, at 11:28 AM, Matthijs Vákár ***@***.***> wrote:
Currently, I was just using a bunch of command line options --<=optional-argument>, which can be combined in any way. I had imagined the behaviour that if you use the --lint or --auto-format options, it goes into linting or pretty-printing mode after semantic check, rather than code generation.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
from stanc3.
VMatthijs
commented on July 29, 2024
Right. That makes sense. What about a --no-generate-cpp option that will turn off code generation? I feel like the default situation is that you do want to generate code and you don't want to pretty print/lint. I feel the options should make the common use case easy. But I agree that it's nicer if all the functionality of the compiler is orthogonal to each other and can be mixed and matched in any way.
from stanc3.
bob-carpenter
commented on July 29, 2024
OK, that makes sense to me. It's not the generation of the C++ that'll take time, but the compilation of it.
… On Dec 14, 2018, at 8:21 AM, Matthijs Vákár ***@***.***> wrote:
Right. That makes sense. What about a --no-generate-cpp option that will turn off code generation? I feel like the default situation is that you do want to generate code and you don't want to pretty print/lint. I feel the options should make the common use case easy. But I agree that it's nicer if all the functionality of the compiler is orthogonal to each other and can be mixed and matched in any way.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
from stanc3.
Related Issues (20)
- [BUG] Array literals in `return` statements may generate wrong type in C++
- [BUG] Tilde syntax does not properly generate promote_scalar for array arguments HOT 7
- [FR] Variadic signatures with external c++ HOT 1
- [FR] Tuple unpacking
- [FR] Expose variadic signatures for `integrate_1d` (deprecate current?) HOT 8
- Expose additional `normal_id_glm` pointwise signatures HOT 2
- Issue a warning when a variable is assigned to itself HOT 5
- [Build] Investigate Melange as an alternative to Js_of_ocaml
- [BUG] atan2 listed as vectorised in manual, vectorised sigs not in stanc3
- Stan compiler Error when using the normal_cdf function HOT 16
- [BUG] Reporting example where new compiler failed HOT 1
- [BUG] stanc3 v. 2.33.1: build error with OCaml 4.14.1 and JaneStreet 0.16.x: `Error: This expression has type [ `Use_Sys_unix ] This is not a function; it cannot be applied`; `Error: Unbound value Set.Poly.union` HOT 4
- Typechecker: Allow predicate-based typechecking of library functions HOT 3
- [BUG] SoA request is ignored with external c++ HOT 5
- Release support for building against ocaml 5 HOT 9
- [BUG] Github action doesn't build static binary for linux platform
- Improve message and handling of internal compiler errors
- [BUG] Array declaration no longer canonicalizes from deprecated format HOT 1
- Iinformative error message for expired array syntax
- CI: Switch from the ghr script to the github CLI
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stanc3.