New feature: Debug mode that warns in the console when stamp props collide. about stampit HOT 12 CLOSED

This seems like a useful feature. When reasoning about an application the developer can more easily keep track of unwanted side-effects. It might also be helpful to have an optional "strict" mode of sorts that prevents prop collision by throwing an error.

from stampit.

I'm not sure we want a strict mode, because it would prevent the very common defaults and overrides pattern.

from stampit.

Could be a per stamp setting maybe to provide a sort of constant prop? I'm only conceptually speaking here, just thought it would be worth considering.

from stampit.

Firstly, I believe all the new features should be introduced after we finalize the 2.0 branch (merge existing PR's, implement #41).

The proposed feature looks useful, although a rare developer would need it. Instead of implementing every feature in the world we could leave extensibility points. For example the three new upcoming functions addMethods, addState, and addEnclose are the very good candidate to be the first point. See possible code sample:

var oldAddState = stampit._addState;
stampit._addState = function (fixed, states) {
  console.log(_.difference(fixed.state, _.merge.apply(null, [].concat(states))));
  return oldAddState(fixed, states);
};

I haven't thought about the extensibility of stampit much. There got to be better ways to do it.

from stampit.

I agree, RE: finalize the 2.0 branch.

I also agree about making Stampit extensible.

However, I also think that static analysis of stamps is essential to Stampit as a tool for building large applications, and a tool that could very easily tell you which stamps are likely to play nice with each other would be very useful, indeed. Integrating it into Stampit core so that you can easily interact with it in the console as you're building the application seems like a very valid use-case to me ...

And it would only take a few lines of code to do it.

from stampit.

Would you please provide a code sample on how you see the

easily tell you which stamps are likely to play nice with each other

?

from stampit.

Rough prototype of how it might work

function checkClashes(objOne, objTwo) {
  var props = Object.keys(objTwo)
  Object.keys(objOne).forEach(function(key) {
    if (props.indexOf(key) !== -1) {
       console.warn('Merge overrides props.')
    }
  })
}

Allows developer to keep track of overrides therefore identifying unwanted overrides.

from stampit.

Clearly we'll want to include more detail in the message (like the key in question). This could happen one time per stamp, after the stamp is applied.

from stampit.

What's stamp is applied?

from stampit.

@koresar Each iteration of this loop.

from stampit.

So, coming back to this issue. It looks alike the #67

Still, I need high level code samples (not the implementation details). How a stampit user would like to use this feature?

from stampit.

Close in favor of #67

from stampit.