stampObject.compose() handy method(s) about stampit HOT 12 CLOSED

Hi,

Thanks again for more fantastic input. I like it.

Method names:

1. Name the append method .composeWith() ?
2. Name the prepend method .composeAfter() ?

Example critique:

Don't use initial caps on anything that isn't a constructor. This is a very common convention in JavaScript and many lint setups will complain about it.

Please submit a PR with:

1. Docs
2. Tests
3. Added methods

And:

Would you like commit access to this project?

We should establish a formal process for commits:

1. Proposal like this on issues page
2. Never commit your own work. Submit a PR and ping me.

I'll follow the same process from now on. That way every new change gets code eyes and code review before it makes it into the main branch.

from stampit.

Hi Eric,

Re the PascalCase. I am forced to reply. :)

In our project we tend to avoid classic constructors and use stamps only. We do not like the idea of putting word 'Stamp' at the end of each stamp variable. Consider:

restAuthServiceStamp.create();
RestAuthService.create();

It is not only about being shorter, but also about consistency. Everything which creates objects should be PascalCased. The team agreed internally and liked it. So far so good.

from stampit.

Re commit access.

That's a great honor to participate in maintaining the stampit

I am an experienced dev and used to maintain few OSS projects, although there is possibility I might screw things up because my JS experience is rather short (~1 year). I wouldn't trust myself. :)

from stampit.

PascalCase works for your project. Understood. For Stampit, we follow
idiomatic JavaScript conventions, so please keep that in mind while writing
pull requests.

Thanks again for your thoughts and contributions. They're much appreciated.
On Aug 17, 2014 6:09 PM, "koresar" [email protected] wrote:

Hi Eric,

Re the PascalCase. I am forced to reply. :)

In our project we tend to avoid classic constructors and use stamps only.
We do not like the idea of putting word 'Stamp' at the end of each stamp
variable. Consider:

restAuthServiceStamp.create();RestAuthService.create();

It is not only about being shorter, but also about consistency. Everything
which creates objects should be PascalCased. The team agreed internally and
liked it. So far so good.

—
Reply to this email directly or view it on GitHub
#28 (comment).

from stampit.

I'm confident that you can handle it, and I promise it won't be a huge time
commitment.

Since I will review all pull requests before they're committed, it's
unlikely that your experience will be problematic.

It's fine if you can't make the commitment, but if it sounds like something
you want to be involved in, the offer stands.
On Aug 17, 2014 6:23 PM, "koresar" [email protected] wrote:

Re commit access.

That's a great honor to participate in maintaining the stampit

I am an experienced dev and used to maintain few OSS projects, although
there is possibility I might screw things up because my JS experience is
rather short (~1 year). I wouldn't trust myself. :)

—
Reply to this email directly or view it on GitHub
#28 (comment).

from stampit.

Ok. I am in.

Expect for PR in 24 hours.

from stampit.

Great!

from stampit.

You are now an official collaborator on this project. Congratulations and welcome aboard! =)

from stampit.

Awesome news! Thank you.

from stampit.

@ericelliott Please let me know if you need any help with optimization.

from stampit.

@wonbyte If you have suggestions, please feel free to submit a PR! =)

from stampit.

OK @koresar -- check out v1.1.0 from npm.. kick the tires. I'm closing this thread. =)

from stampit.