Code Monkey home page Code Monkey logo

Comments (6)

waseem-h avatar waseem-h commented on May 27, 2024

Do you have any idea on how would you approach this? Can we somehow look for NetworkPolicy or PodSecurityPolicy and add the indication based on that? Or should we just have a simple annotation that needs to be explicitly set by the user to indicate that this is a network restricted service? @usamaahmadkhan

from forecastle.

usamaahmadkhan avatar usamaahmadkhan commented on May 27, 2024

How about adding a default check for nginx-ingress annotation. external-ingress means it is public and internal-ingress means it is network restricted.

from forecastle.

waseem-h avatar waseem-h commented on May 27, 2024

I believe that is just our usecase that we have 2 different nginx ingress controllers with specific names internal-ingress and external-ingress. Implementing it like you mentioned would restrict users to use this feature in many ways. Lets say they don't even run an nginx controller and they don't have annotations specified for their controller. I think we need to approach this in a more generic and decoupled way in which our scenario can also easily fit

from forecastle.

usamaahmadkhan avatar usamaahmadkhan commented on May 27, 2024

Then NetworkPolicy should do it. We should assign labels like network-restricted=true/false to pod that require restriction and then use PodSelector in NetworkPolicy to restrict those pods. Similarly watching these labels when adding a mark on the UI.

from forecastle.

waseem-h avatar waseem-h commented on May 27, 2024

@usamaahmadkhan I think we should start from the basic, i.e., allow users to specify whether an app is network restricted or not manually. And then support automatic detection. Partial support is already in for this in #78 . We can use the annotation forecastle.stakater.com/network-restricted to specify if an app is restricted or not

from forecastle.

waseem-h avatar waseem-h commented on May 27, 2024

The feature has been implemented in #80

from forecastle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.