Code Monkey home page Code Monkey logo

Comments (4)

SatsAllDay avatar SatsAllDay commented on September 26, 2024 1

Yea, that makes sense.

As far as I can tell, mentions are only used for notifications to the mentionee. And we also filter out self mentions in those queries, so I don't see any reason to create them in the DB. My PR makes that change.

from stacker.news.

ekzyis avatar ekzyis commented on September 26, 2024 1

but even sane usage might lead someone to quote a mention of themselves

yes, in my case, I think I just quoted a reply in which I was mentioned

from stacker.news.

SatsAllDay avatar SatsAllDay commented on September 26, 2024

I'll work on this one, should be pretty straight-forward.

Side note: should we even create mentions in the DB when we mention ourselves? Skipping the push notification is simple, but I wondered if the mentions should exist at all.

from stacker.news.

huumn avatar huumn commented on September 26, 2024

They shouldn't exist really ... I think I just assumed no one would do that ... but even sane usage might lead someone to quote a mention of themselves

from stacker.news.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.