Comments (9)
Let me know if you have questions. I am happy to help (you can also find me in the bitcoin design slack)
from stacker.news.
I was thinking of the most simple WebLN integration. (so without changing the concept that the user has an account and a balance).
we could simply check for webln on the QR topup page: https://github.com/stackernews/stacker.news/compare/master...bumi:webln?expand=1 (pseudo code - because I could not run it)
the idea is, that it checks of WebLN is available, if so it hands over to WebLN. if NOT it shows the current flow with the QR code
from stacker.news.
Thanks for this! This is roughly the level of change required to support WebLN? Much less work than I thought
from stacker.news.
Yeah, just call some JS instead of showing a QR code. + some error handling (and showing the QR code in the error case)
from stacker.news.
Right on, I'll reprioritize this. Might be able to cram it in today even.
from stacker.news.
Hey @bumi, deployed this. SN now supports both fund and withdrawals through WebLN. Tested it with Joule - seems to work well. Thanks for giving me the push!
Lmk if you have any gripes.
from stacker.news.
whoop whoop! you're fast. works great!
Though I would only show the QR code if WebLN is NOT available or the WebLN request fails. - I find doing both a bit confusing...
is there a reason why you do it like this? (In my code I tried to do that with the useWebln
state.)
from stacker.news.
I don't disagree but a blank page is also confusing - in a different way. This is just version get.it.done. On my MacBook Air the popup from Joule covers most of the page, so it also didn't seem too confusing too. Up to changing it though if your experience differs significantly.
from stacker.news.
I'd show a loading spinner instead.
Our extension currently pretty quickly closes the popup after confirmation and it takes a second until the payment is done.
So I guess there the QR code is visible longer.
I also think the idea is that most should be handled in the website (e.g. also error handling) - so we do not wait but leave it up to the website.
from stacker.news.
Related Issues (20)
- Show pubkey of users logged in with Lightning
- Add ability to subscribe to threads HOT 5
- Number of posts shown in top cowboys page is incorrect - Bug HOT 1
- /settings while not authenticated gives an HTTP 500
- UX enhancement request: Ctrl-click on yellow buttons to open in new tab HOT 2
- Dupes check doesn't work for URL with port
- duplicate notifications HOT 1
- Make browser notifications double opt-in
- Improving Free Posts & Free Post Communication
- Pay bounty still visible after bounty was paid HOT 4
- UX: Scrolling to collapsed comments does not uncollapse them HOT 2
- Prediction Markets on SN HOT 7
- Feature Request: Making Advertisements Fun on Stacker News
- Reuse code routes/pages between subs and home
- Cursor jumps to start on first keypress after entering edit mode HOT 2
- Feature Request: New User Email Onboarding
- Feature Request: Permanent Daily Discussion URL
- Twitter login attempt gives "Try signing with a different account." HOT 5
- No mention after markdown link
- Prevent formatting links as markdown links
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from stacker.news.