Comments (2)
GalRogozinski
commented on September 16, 2024
Two options:
-
Create two types
SignedQBFTMessageandSignedPartialSigMessage.
This would get ugly though when trying to decode the proper message with ssz lib. -
Pass both the Signed wrapper and the inner message. All logic would be done on the inner message, but the final broadcast will be done on the wrapper.
from ssv-spec.
GalRogozinski
commented on September 16, 2024
Currently we solved with option 2 in #440
from ssv-spec.
Related Issues (20)
- `DecidedValue` in BaseRunner has a misleading name.
- Update Alan fork epoch in spec
- we printed errors instead of returning them HOT 2
- We can't reach Message Type error in tests that comes from `baseCommitValidationIgnoreSignature`
- can we use one of the sign functions in the runners instead of repeating this code?
- instead of storing a map of shares here, i think we should store map of shares in CommitteeRunner and only a single share in the other runners HOT 1
- i think we can remove all getters that dont do any computation (in all code not just here)
- Sort signers in decided messages
- Don't process QBFT messages after instance is decided HOT 2
- PRs that should be merged for CC HOT 1
- Seperate tests.json files to smaller files
- A spec probably shouldn't care about whether the key is PKCS1 or PKCS8 encoded HOT 2
- ControllerSpecTest doesn't use OutPutMessagesField
- Separate base runner for committee and other runners HOT 1
- Update PKCS1 to PKCS8
- Remove unused Subscriber interface
- GetSignatureDomainType() from qbft config is unused HOT 1
- Use pointer in structure's methods
- Pass slashable validators shares (attestation duties) to CommitteeRunner when starting a duty
- bug: Incorrect type conversion in GetCommitteeID
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ssv-spec.