Comments (4)
GalRogozinski
commented on September 16, 2024
For duty tests we skip broadcasted consensus messages:
ssv-spec/ssv/spectest/tests/runner/duties/newduty/test.go
Lines 55 to 58 in 548cb4f
we shouldn't do that... we should test consensus messages as well imo...
Maybe it was dont this way to seperate runner from consensus, but we run consensus instance in the test
from ssv-spec.
GalRogozinski
commented on September 16, 2024
Add ValueCheck tests
from ssv-spec.
GalRogozinski
commented on September 16, 2024
We should test the following scenarios:
- With
invalid_quorum_then_valid_quorumwe should have byzantine test where some roots have a valid root while others don't. We need to see that a 4th message fixes the invalid ones - Test with validators on different committees. We need to make sure the committee indexes are not getting mixed up after post consensus stage.
- We need to make sure we use proper eth domains.
Currently scenario 3 is implicitly tested because the info is in the broadcasted root (so it is good enough). For 2 we are missing the input.
from ssv-spec.
GalRogozinski
commented on September 16, 2024
Done
from ssv-spec.
Related Issues (20)
- `DecidedValue` in BaseRunner has a misleading name.
- Update Alan fork epoch in spec
- we printed errors instead of returning them HOT 2
- We can't reach Message Type error in tests that comes from `baseCommitValidationIgnoreSignature`
- can we use one of the sign functions in the runners instead of repeating this code?
- instead of storing a map of shares here, i think we should store map of shares in CommitteeRunner and only a single share in the other runners HOT 1
- i think we can remove all getters that dont do any computation (in all code not just here)
- Sort signers in decided messages
- Don't process QBFT messages after instance is decided HOT 2
- PRs that should be merged for CC HOT 1
- Seperate tests.json files to smaller files
- A spec probably shouldn't care about whether the key is PKCS1 or PKCS8 encoded HOT 2
- ControllerSpecTest doesn't use OutPutMessagesField
- Separate base runner for committee and other runners HOT 1
- Update PKCS1 to PKCS8
- Remove unused Subscriber interface
- GetSignatureDomainType() from qbft config is unused HOT 1
- Use pointer in structure's methods
- Pass slashable validators shares (attestation duties) to CommitteeRunner when starting a duty
- bug: Incorrect type conversion in GetCommitteeID
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ssv-spec.