Comments (4)
molnarzs
commented on May 18, 2024
1
Just a comment, we also had this problem, we worked around with the attached patch:
@serverless-stack+cli+0.20.0.patch.zip
So if there is no PR yet I could even create it
from sst.
smoll
commented on May 18, 2024
Looking at the code, it looks like there is nothing that checks to see if any of the final stackStates are in a failed state.
Would you accept a PR for this? What do you think the behavior should be, to exit non-zero if any of the stacks failed?
Would it be better if this were a flag, e.g. something like --error-on-failed-states? TBH, even just writing that feels awkward. I think changing it to exit non-zero on any failures is the least surprising default behavior.
from sst.
jayair
commented on May 18, 2024
@smoll Thanks for looking into it. Yeah the non-zero status is the right behavior for sure. We'd appreciate a PR!
from sst.
fwang
commented on May 18, 2024
This has been fixed in v0.23.0
@smoll @molnarzs Thank you guys for bringing this up.
from sst.
Related Issues (20)
- SvelteKit adapter: Incorrect Content-Type header for __data.json HOT 2
- Option to pass `buildOutputPath` to OpenNext when using the NextjsSite construct
- Is top-level await really necessary? HOT 4
- Caching issue when using custom hook built with Context HOT 1
- How to get long running job status and result
- Certificate Requestor still failing in Node v18 HOT 1
- ApiLambdaAuthorizer fails if not an async function HOT 1
- Cannot deploy Python container using Service construct HOT 3
- PFR: automatically add `awsApplication` tag to all resources created by SST to enable new "myApplications" AWS feature HOT 3
- NextJs Site getting error "Cannot find module 'next/dist\client\components\static-generation-async-storage.external.js'" HOT 2
- Cloudformation Termination Protection and Confusion with setDefaultRemovalPolicy HOT 3
- Typescript suddenly incompatible between SST and CDK constructs HOT 6
- Support Astro v4
- Deployment of Astro Starlight sites is broken
- CommonJS in Node runtime
- How to get node-canvas layer working with live lambda HOT 1
- SST prisma example is broken HOT 1
- HTTP_PROXY support via global-agent is broken HOT 4
- Support Node 20 (Update fast-jwt, EBADENGINE for <20) HOT 1
- FeatureRequest: Provide a way to use TypeBox as scheme provider for EventBus HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sst.