Add 'stage' property to Stack construct about sst HOT 6 CLOSED

Ah I see. Sorry, I miss read your code.

If we made stage available in the Stack object, would that work for you? So inside your SubStack, you can do this.stage instead of props.stage.

from sst.

@justindra I'm working on supporting stack.stage in PR #240

I'm going to change the title for this issue to this. And I opening a discussion for this instead https://github.com/serverless-stack/serverless-stack/discussions/244

from sst.

While you are looking at this, would it be possible to add the stage into the Stack? Atm I have to pass in the stage into my custom resources as a prop. It would be nice to be able to acces it from the Stack itself instead of having to repetitively pass it in as a prop.

import { Stack, App, StackProps } from '@serverless-stack/resources';

export class MyStack extends Stack {
    constructor(scope: App, id: string, props?: StackProps) {
        super(scope, id, props);

        new SubStack(this, id, { stage: scope.stage }); // <-- be nice if we can just get the stage from `this`
        new CustomResource1(this, id, { stage: scope.stage });
        new CustomResource2(this, id, { stage: scope.stage });
    }
}

// vs

export class MyStack extends Stack {
    constructor(scope: App, id: string, props?: StackProps) {
        super(scope, id, props);

        new SubStack(this, id);
        new CustomResource1(this, id);
        new CustomResource2(this, id);
    }
}

Currently I've got my custom Stack object that does this, but might be nice to have it as part of the framework.

from sst.

Hi @justindra, are you creating a nested stack?

from sst.

@fwang Not at the moment, its just custom TS Classes to tidy up and make some resources more re-usable. E.g. I have a Table class that creates a DDB Table, Lambda Hooks and CFn Outputs. But possibly some nested stacks in the future too.

from sst.

Yep @fwang that would be perfect!

from sst.