Comments (11)
I am not 100% sure but I believe this is the problem with 2.2.0:
elastic/elasticsearch#14577
It might have been fixed in 2.3.0:
elastic/elasticsearch#16758
Although I am not completely sure yet.
from elasticsearch-readonlyrest-plugin.
I've tested the same codebase with 2.3.0 and the problem is gone. Which confirms that was the problem.
from elasticsearch-readonlyrest-plugin.
Interesting, no idea. I will try to put some printf and hopefully see what and why this happens. BTW, thanks Paolo for the features and insights you are contributing to this project!
from elasticsearch-readonlyrest-plugin.
Can't reproduce, mind sharing the conf file?
from elasticsearch-readonlyrest-plugin.
Sure (it includes aliases):
readonlyrest:
enable: true
response_if_req_forbidden: Sorry, your request is forbidden.
access_control_aliases:
- in: paolo
out: [helloworld]
access_control_rules:
- name: Accept all requests from localhost
type: allow
hosts: [127.0.0.1]
#indices: [paolo]
- name: Accept only GETs from other host
type: allow
methods: [GET]
indices: [translational]
from elasticsearch-readonlyrest-plugin.
Copied your conf exactly, sent a few requests to match both the blocks, my printf in the "IndicesRule.match" function prints just once.
The only thing I manage to print twice is if I add a printf in the upper part of the IndicesRule constructor, as it's called for every block.
from elasticsearch-readonlyrest-plugin.
It might be a regression on my side.
If (in IndexLevelActionFilter) I change this:
if (exitResult.isMatch() && exitResult.getBlock().getPolicy() == Block.Policy.ALLOW) {
return true;
}
To:
if (exitResult.isMatch() && exitResult.getBlock().getPolicy() == Block.Policy.ALLOW) {
logger.info("[readonlyrest] Request passed");
return true;
}
The logger prints always twice.
UPDATE
I just checked out the latest from the repository, performed the change above, compile, deployed and I get the double print. I was hoping to pipeline different kind of elements but if this is the case I have some restrictions.
from elasticsearch-readonlyrest-plugin.
That would explain why I could not reproduce :)
from elasticsearch-readonlyrest-plugin.
If that is the case, what I was trying to implement will not be working the same for 2.2.0. Which is a little disappointing. @sscarduzio I will try to outline my game plan in the next few days to see if these are features you are interested in adding to the plugin. And we will go from there.
from elasticsearch-readonlyrest-plugin.
this 2.2.0 sounds like a really crappy release for readonly rest plugin. Not only your filter won't work, but all the filters will be inefficient and produce double logging. We could probably skip that build and have a warning in the docs about our reasons. Thoughts?
PS: Looking forward to seeing what you're up to, @pciccarese :)
from elasticsearch-readonlyrest-plugin.
Closing this as it's an ES bug. Thanks for investigating on this @pciccarese
from elasticsearch-readonlyrest-plugin.
Related Issues (20)
- Does this work on ES 7.10.0? HOT 2
- Support for certificates in PEM format, in addition to keystore format HOT 3
- despite force_load_from_file=true, ROR plugin tries to load .readonlyrest index HOT 2
- Kibana Short url creation not recognised on Kibana 7.8.1 HOT 4
- When user access a forbidden resource, the user cannot access to kibana dashboards in 7.5.1 HOT 3
- Can't Update Kibana to 7.12.0 with ROR enabled HOT 6
- Curator can't create backup with ROR enabled HOT 7
- 请问配置更新有api吗? HOT 3
- Potential security issue HOT 7
- elasticsearch7.15.1 安装后启动报错
- Why are 403 response codes sent while ROR plugin isn't initiated? HOT 5
- No Tag in Github for Version v1.39.0-pre4_es7.17.3 HOT 4
- Indices rule not working for data stream ES 7.17 HOT 11
- How configure in docker compose with this plugin HOT 3
- Unable to make field private static final java.util.Map
- kibana_access is not working (_bulk_resolve are blocked) HOT 12
- Error while installing ror plugin inside docker container HOT 2
- Unable to connect to LDAP server HOT 2
- Can't able to authenticate with LDAP HOT 14
- Kibana ::1:<port> ECONNREFUSED HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elasticsearch-readonlyrest-plugin.