Comments (10)
Depending on how you run it you'll have to do RAILS_ENV="development" (which is implicit) or RAILS_ENV=production. "test" should only be used to run goldberg's own tests.
from goldberg.
@srushti, I did not get what you mean by goldberg's own tests.
Although, I won't be comfortable hardcoding RAILS_ENV=test
, because if someone wants to override it or change it, they won't be able to do so because of this hardcoding. We can probably mention in the documentation that, people can mention RAILS_ENV=test
in the custom command if this is intended behavior.
from goldberg.
@aakashd Maybe I misunderstood the original problem, but it looked like he only had goldberg's test database configured & defined. I was mentioning that you don't want to run goldberg on the test database, since that is to be used to run goldberg's own specs, and that while running the app you want to use one of the other two configurations (after having defined it in the database.yml, of course).
from goldberg.
I expect goldberg to act as a continuous integration platform. As such, I expect it to run my tests and only my tests against my code. If it is running my tests (ie my rspecs), then I expect goldberg to execute them against my test database. I don't know why I should have created a development database for goldberg to function.
I believe the original intent of goldberg was to run on a local development machine. If this the case, it explains why you haven't seen this error before. I'd like to run goldberg on a standalone continuous integration machine. It's my plan to have 20 projects being tested on this machine. That's why I'd like to just create the needed 20 test databases for those projects, (not the 20 test databases plus the unnecessary 20 development databases).
If this isn't making sense, I'd be happy to setup a skype call.
To review, I expect RAILS_ENV=test to be the default behavior
from goldberg.
The situation you describe makes sense, but I must be missing something, because I'm not sure what exactly you want. Possibly, @aakashd understood it better. I've replied directly to the email address from your commits with my skype id. Let me know what a good time is to have that call.
from goldberg.
Thanks for the great skype call. I'll ask around here to see if I"m the only person who sets up their CI environment with just test databases or if it is standard practice to setup a test and development database. (If its the later, I'll conform to the norm.)
from goldberg.
I'm closing this since we now have the ability to do what you want in a more generic way. You can add environment_variables through goldberg_config, which in your case would be "RAILS_ENV=test".
It looks like cc.rb does do this by default, but I'm still not sure we want to be prescribing this.
from goldberg.
I've asked around locally here in Silicon Valley, and quite a few people
think that a build machine should NOT have a development database.
Todd
On Sun, May 1, 2011 at 10:56 PM, srushti <
[email protected]>wrote:
I'm closing this since we now have the ability to do what you want in a
more generic way. You can add environment_variables through goldberg_config,
which in your case would be "RAILS_ENV=test".
It looks like cc.rb does do this by default, but I'm still not sure we want
to be prescribing this.Reply to this email directly or view it on GitHub:
#40 (comment)
from goldberg.
Yeah, fair enough. Just wondering if a ci server should enforce it, or expect the users to know what they're doing and do it themselves.
from goldberg.
I guess the question is what user base do you want to attract. Do you only want to cater to build engineers, or do you want to also cater to software developers? The first group will be able to figure it out. The second group may not have much time to deal with assumptions made by goldberg. If goldberg is going to make assumptions, that's fine, but they should be more clearly articulated in the README file.
from goldberg.
Related Issues (20)
- Perform a git-reset before doing a git pull HOT 1
- Poller Error "cannot start a transaction within a transaction" HOT 7
- Fix home page refresh HOT 6
- RVM fails to work properly if the .rvmrc is checked in HOT 3
- Use .rvmrc ruby if it exists
- suggestion: culprit checking code shouldn't be in view HOT 6
- allow periods (.) in project names HOT 6
- Portability issues / suggestions HOT 6
- time of _projects.html.haml and builds.html.haml not necessarily in sync HOT 4
- svn cleanups HOT 2
- suggestion: making running more complex build commands easier HOT 4
- not easy to run! HOT 7
- Measure & Report on build times HOT 1
- Show commit message on the build page HOT 1
- Doesn't send any mail notification upon build completion HOT 6
- Show status as success even build has been failed HOT 2
- Updated configuration page with jruby configuration HOT 4
- Run ajax functionality specs using goldberg HOT 2
- Capybara specs are failing some time on goldberg HOT 1
- Not able to run specs through goldberg
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from goldberg.