Conflict between node-minify and cluster modules about node-minify HOT 6 CLOSED

It seems to be failing when deleting the temporary file.
I don't think that is related to the cluster.
Can you show me the content of your minify.js ?

from node-minify.

It only happens when clustering, and then only intermittently. At first I thought it might be a shared ./tmp directory, but renaming it didn't help. Also didn't matter which compressor I used.

minify.js:

/* concatenate and minify js, css files */
var compressor = require('node-minify')
,async = require('async')
;

module.exports = minify = function(options, callback) {
var cssCompress = options.compress? 'yui-css' : 'no-compress'; // Using YUI Compressor for CSS
var jsCompress = options.compress? 'uglifyjs' : 'no-compress'; // Using UglifyJS Compressor for JS

async.parallel([
    function(cb) {
        new compressor.minify({
            type: cssCompress,
            tempPath: 'tmp/',
            fileIn: [
        //...
            ],
            fileOut: '../htdocs/css/min/base.css',
            callback: cb
        })
    },
    function(cb) {
        new compressor.minify({
            type: cssCompress,
            tempPath: 'tmp/',
            fileIn: [
        //...
            ],
            fileOut: '../htdocs/css/min/spry.css',
            callback: cb
        })
    },


     function(cb) {
        new compressor.minify({
            type: jsCompress,
            tempPath: 'tmp/',
            fileIn: [
        //...
                ],
            fileOut: '../htdocs/javaScript/min/core_min.js',
            callback: cb
        })
    },

    function(cb) {
        new compressor.minify({
            type: jsCompress,
            tempPath: 'tmp/',
            fileIn: [
        //...
                ],
            fileOut: '../htdocs/javaScript/min/core_deferred_min.js',
            callback: cb
        })
    },

    function(cb) {
        new compressor.minify({
            type: jsCompress, 
            tempPath: 'tmp/',
            fileIn: [
        //...
                ],
            fileOut: '../htdocs/javaScript/min/login_deferred_min.js',
            callback: cb
        })
    },

    function(cb) {
        new compressor.minify({
            type: jsCompress,
            tempPath: 'tmp/',
            fileIn: [
        //...
                ],
            fileOut: '../htdocs/javaScript/min/review_deferred_min.js',
            callback: cb
        })
    },

    function(cb) {
        new compressor.minify({
            type: jsCompress,
            tempPath: 'tmp/',
            fileIn: [
        //...
                ],
            fileOut: '../htdocs/javaScript/min/spry_min.js',
            callback: cb
        })
    }
], callback

)};

if (!module.parent) { //running standalone
var isCompress = process.argv.indexOf('nocompress') == -1;

minify({compress: isCompress}, function(err, results){
    if(err) console.log(err);
});

}

On Mar 11, 2014, at 12:01 PM, Rodolphe Stoclin wrote:

It seems to be failing when deleting the temporary file.
I don't think that is related to the cluster.
Can you show me the content of your minify.js ?

—
Reply to this email directly or view it on GitHub.

from node-minify.

I have just release 0.9.2, can you test with it ?
And also, the cluster is firing your minify for each cluster.
You have to do that in the master instead.
Here what I was testing and work well :

(function(){
  var cluster = require('cluster'),
    numCPUs = require('os').cpus().length;

  if (cluster.isMaster) {
    minify({compress: true}, function(){
      console.log('ok compress');
    });

    // Fork workers
    for (var i = 0; i < numCPUs; i++) {
      var worker = cluster.fork();
    }

    cluster.on('death', function (worker) {
      var newWorker = cluster.fork();
    });
  } else {
        var port = parseInt(config['port']);
        server.listen(port);
  }
})();

from node-minify.

Oh, thanks for explaining that. I hadn't realized each process was re-executing the whole script. I will try 0.9.2 later today.

-- Jeff

On Mar 12, 2014, at 11:06 AM, Rodolphe Stoclin wrote:

I have just release 0.9.2, can you test with it ?
And also, the cluster is firing your minify for each cluster.
You have to do that in the master instead.
Here what I was testing and work well :

(function(){
var cluster = require('cluster'),
numCPUs = require('os').cpus().length;

if (cluster.isMaster) {
minify({compress: true}, function(){
console.log('ok compress');
});

// Fork workers
for (var i = 0; i < numCPUs; i++) {
  var worker = cluster.fork();
}

cluster.on('death', function (worker) {
  var newWorker = cluster.fork();
});

} else {
var port = parseInt(config['port']);
server.listen(port);
}
})();
—
Reply to this email directly or view it on GitHub.

from node-minify.

0.9.3 works like a charm.

On Mar 12, 2014, at 11:06 AM, Rodolphe Stoclin wrote:

I have just release 0.9.2, can you test with it ?
And also, the cluster is firing your minify for each cluster.
You have to do that in the master instead.
Here what I was testing and work well :

(function(){
var cluster = require('cluster'),
numCPUs = require('os').cpus().length;

if (cluster.isMaster) {
minify({compress: true}, function(){
console.log('ok compress');
});

// Fork workers
for (var i = 0; i < numCPUs; i++) {
  var worker = cluster.fork();
}

cluster.on('death', function (worker) {
  var newWorker = cluster.fork();
});

} else {
var port = parseInt(config['port']);
server.listen(port);
}
})();
—
Reply to this email directly or view it on GitHub.

from node-minify.

Glad to hear that :)

from node-minify.