Ignore SET keyword about go-mysql-server HOT 6 CLOSED

Closing this as is not needed to ignore set anymore, it is already implemented.

from go-mysql-server.

SET SESSION TRANSACTION ISOLATION LEVEL REPEATABLE READ is not even parseable by vitess.

This is the full list of queries executed by MySQL workbench.

set autocommit=1
SET SESSION TRANSACTION ISOLATION LEVEL REPEATABLE READ
SHOW SESSION VARIABLES LIKE 'lower_case_table_names'
SELECT current_user()
SET CHARACTER SET utf8
SET NAMES utf8
SHOW SESSION VARIABLES LIKE 'sql_mode'
SELECT CONNECTION_ID()
SHOW SESSION STATUS LIKE 'Ssl_cipher'
USE `db`
SHOW GLOBAL STATUS

Even after passing all those queries, the following error is shown by the app:

I don't know if all this is worth the work it implies for the time being.

from go-mysql-server.

It may not be worth for the first version. We may also want to test other clients, for example:

• DbVisualizer
• DBeaver
• sqlectron

from go-mysql-server.

Ignoring the SET keyword altogether might not be desirable, since the client might be expecting that those SET have a particular behaviour. Maybe this issue should be changed to just look into what we can do to make it compatible with MySQL Workbench?

from go-mysql-server.

@smola yep. SET is implemented in #129, but vitess does not support the syntax of all the SET commands workbench sends.

Here's #63 (comment) the full list of commands we need to support for that

from go-mysql-server.

We don;t need to support workbench or any other admin tool, the request of ignoring the SET was a quick solution to make it work, but if it requires any mid/big work, we are not going to do oit.

from go-mysql-server.