Code Monkey home page Code Monkey logo

Comments (10)

squidfunk avatar squidfunk commented on May 3, 2024 1

Hmm, well the debug window doesn't include the iframe, so that's the main problem I guess. Probably karma-viewport has to be extended so that it inserts an iframe itself. I need to think about this a little but this is indeed a bug.

from karma-viewport.

squidfunk avatar squidfunk commented on May 3, 2024 1

My fault, there was a broken reference which the tests didn't catch. Please try 0.2.1 which was just released.

from karma-viewport.

squidfunk avatar squidfunk commented on May 3, 2024

See #13. The solution is a little hacky, as I had to override the debug.html injection logic and embed it into the standard iframe context. However, it's the best possible solution as it has minimal impact for the way tests are structured and built and works interop with all other karma modules. I will issue a release within in a few hours when the build passes.

from karma-viewport.

squidfunk avatar squidfunk commented on May 3, 2024

Just released 0.2.0 which should solve your problem. I could only test within a vanilla JavaScript context, as I don't have an Angular project on my hands. Could you please verify?

from karma-viewport.

Tipster74743 avatar Tipster74743 commented on May 3, 2024

Yes sir, I will verify in just a moment.

from karma-viewport.

Tipster74743 avatar Tipster74743 commented on May 3, 2024

This is what I'm getting now:

01 08 2017 14:14:00.184:ERROR [karma]: ReferenceError: query is not defined
    at fs.readFile (../node_modules/karma-viewport/dist/index.js:110:13)
    at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:504:3)

Did I miss something by chance?

from karma-viewport.

squidfunk avatar squidfunk commented on May 3, 2024

That is really strange. Which Node version are you using?

from karma-viewport.

Tipster74743 avatar Tipster74743 commented on May 3, 2024

That fixed it, it is now working as intended. Thank you!

from karma-viewport.

squidfunk avatar squidfunk commented on May 3, 2024

Thank you for the report! Feel free to provide feedback as this is a very young project.

from karma-viewport.

anvlkv avatar anvlkv commented on May 3, 2024

Hi, suddenly I have this issue now with "karma-viewport": "^1.0.4" , "karma": "^3.1.4", and "jasmine-core": "~3.3.0"

And it would only happen when I'm running a single spec in debug mode.

from karma-viewport.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.