Code Monkey home page Code Monkey logo

Comments (7)

jasnell avatar jasnell commented on May 10, 2024

SETTINGS persistence is currently considered "at risk" in the http/2 spec, so it's likely best to continue holding off on implementing support ;-)

from okhttp.

swankjesse avatar swankjesse commented on May 10, 2024

Great, thanks for the heads up.

from okhttp.

swankjesse avatar swankjesse commented on May 10, 2024

Closing for now. Will revisit when we start to build out HTTP/2.0 support.

from okhttp.

madongfly avatar madongfly commented on May 10, 2024

Can you consider this now?

We (gRPC-java) are going to use MAX_CONCURRENT_STREAMS (grpc/grpc-java#181), can we at least public the get/set method of Settings?

from okhttp.

swankjesse avatar swankjesse commented on May 10, 2024

At the moment GRPC is using only a small part of OkHttp's codebase. And it's using code from our internal package, which means we don't promise API or binary compatibility between any releases.

I think our best next step is for GRPC to copy the relevant classes from OkHttp into GRPC. You can add whatever features you need, and we can avoid breaking you as we change our code.

I think GRPC should continue to use Okio, which is what makes it possible to build an HTTP/2 client without much code.

from okhttp.

swankjesse avatar swankjesse commented on May 10, 2024

Also, if you do copy HTTP/2 code into GRPC, and implement a bunch of new stuff, there's nothing stopping us from folding those improvements back into OkHttp proper. But I think a library-dependency is a bad fit until we offer public APIs for low-level HTTP/2 operations. (Which we aren't planning!)

from okhttp.

louiscryan avatar louiscryan commented on May 10, 2024

I guess another option on the table would be to provide a proguard stripped version of Netty that was GRPC-on-Android specific, no idea what that would end up looking like.

from okhttp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.