Delete statements with joins not supported about querybuilder HOT 6 CLOSED

Thanks for reporting, yes currently these cases are not supported in DELETE, INSERT and UPDATE statements, the main reason is that the join method is not supported in all db engines, for example in Postgres, so don't know what is the best way to handle this, maybe we can:

1. converting the join to a CTE or subquery (while I don't recommend such implicit conversion)
2. or throw an exception to the user for the unsupported engines
3. or compile it and let the user handle these cases
   4 or ignore it at all (current)

What do you think ?

from querybuilder.

for the moment, I agree that we should mention this in the docs, could you open an issue there please, or I do it myself ?

from querybuilder.

I will open the issue there later if I don't see it already.

Yeah, I don't think making the implicit conversion is the way to go--I was just looking up the USING statement in postgres but I'd have to come back to that.

In a local dev branch, I've started to build onto the UPDATE/INSERT for sqlserver compiler as well as add tests. I think since the library already just ignores the unsupported statement it can stay that way until someone finds a reason not to silently ignore it.

from querybuilder.

Any updates on adding join to insert/update/delete. Eagerly waiting for it. Was looking for a solution for SQLServer.

from querybuilder.

@punssoma
Do you have a proposal on how this can be accomplished in the following database:

• Sql Server
• MySql
• PostgreSql

for the time being I suggest using subqueries something like

// delete the books where with AuthorId = 1
db.Query("Books").WhereIn("Id", q => q.From("Books").Join("Authors").Where("Authors.Id", 1).Select("Id"))

from querybuilder.

@ahmad-moussawi Thanks for the tip.
No proposal as of now. Let me try something locally and then may be i can suggest

from querybuilder.