Code Monkey home page Code Monkey logo

Comments (14)

4kimov avatar 4kimov commented on August 16, 2024 1

Right on 💪 Let me know if you have questions/etc

from sqids-java.

lukechen116 avatar lukechen116 commented on August 16, 2024 1

@0x3333 / @fanweixiao, thank you for all the help! Please let me know if anything else is needed or suggested.
@4kimov Could you invite @0x3333 to be the maintainer for this repo?

from sqids-java.

fanweixiao avatar fanweixiao commented on August 16, 2024

Hi @4kimov, working on the first impl, hope will push in next week.

from sqids-java.

0x3333 avatar 0x3333 commented on August 16, 2024

Hi @4kimov, working on the first impl, hope will push in next week.

Which minimum java version will be supported?

from sqids-java.

4kimov avatar 4kimov commented on August 16, 2024

@fanweixiao How's it going with this repo?

from sqids-java.

lukechen116 avatar lukechen116 commented on August 16, 2024

Hello @4kimov, I implemented Java code for Sqids. I would like to contribute this code and upload branch. How do I provide?

from sqids-java.

4kimov avatar 4kimov commented on August 16, 2024

Hi @lukechen116, nice - thank you & good job 👍 Sent you an invite to be a maintainer. Feel free to remove the CHANGELOG, release package, etc

I'll update the site shortly.

Edit: Btw, in the README examples, are there missing semicolons at the end of encode/decode lines or is it meant to be this way?

from sqids-java.

lukechen116 avatar lukechen116 commented on August 16, 2024

@4kimov I changed constructor to Gang of Four (GoF) design Builder pattern that is friendly readable code and constructor default parameters are reduced. Would you update official site example code?

from sqids-java.

4kimov avatar 4kimov commented on August 16, 2024

@lukechen116 No problem, updated. Let me know if anything else needs adjusting.

  1. Could we have Github Actions to auto-test on push, like the other repos?
  2. I'm guessing CHANGELOG is not common in Java packages, should we remove that file?

from sqids-java.

lukechen116 avatar lukechen116 commented on August 16, 2024

@4kimov Thank you.

  1. Setup completed. This is my first time using GitHub Actions, so it took a little longer. Sorry for the delay.
  2. CHANGELOG doesn't affect the Java project or packages. I'm keeping it for future use.

from sqids-java.

4kimov avatar 4kimov commented on August 16, 2024

@lukechen116 Perfect, thank you 👍

from sqids-java.

lukechen116 avatar lukechen116 commented on August 16, 2024

Hello @4kimov / @fanweixiao / @0x3333
I have tested it almost.
Could you assist me to package and publish it to the Maven repository for public use?

from sqids-java.

fanweixiao avatar fanweixiao commented on August 16, 2024

Hi @lukechen116, the maven repository is maintained by @0x3333, he will help in this. But he's got busy these days.

from sqids-java.

0x3333 avatar 0x3333 commented on August 16, 2024

I'll issue a PR with the settings to Gradle to allow publishing to the Maven repo. I'll ask for some time, as things are really stacking up here.

from sqids-java.

Related Issues (6)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.