Refactor Value interface about sabre HOT 2 OPEN

Yep agreed on all. Performance is not big enough concern to warrant any targeted optimization but I would still like to keep the overhead to minimum. I've decided to keep it as is for now. We can think about this again at some point later..

from sabre.

If we go for option 1, I think we should at least give the empty interface a type, e..g: type Value interface{}. This achieves two things:

1. keeps things readable (avoids questions like "is this a Sabre interface{} or something else?)
2. allows us to easily add methods to the interface later, if needed.

Note that there is precedent for this approach.

Concerning option 2, I'm not sure what we obtain from having the Source() method.

Option 3 is also fine. It avoids a type assertion, which has performance implications. I'm not sure how much we care about this, though.

Ultimately it's up to you -- I don't have strong feelings about this either way.

from sabre.