Comments (3)
Hi, @tienbuide,
thank you for your contribution.
This should have been fixed here - https://github.com/spryker/docker-sdk/releases/tag/1.14.1
from docker-sdk.
hey @alexanderM91,
thanks for not letting me be a contributor by accepting my pull request and copying (almost) everything of it instead
¯\_(ツ)_/¯
from docker-sdk.
Hey @tienbuide we have a complex process and we're working on figuring out our contributor guidelines right now. Our team has a specific process we follow for merging work to master which @alexanderM91 followed correctly. I don't think anyone here wanted to remove credit from your contribution but I'll escalate this internally so we can adjust our process guidelines and we can do better in the future.
For additional transparency: 800+ of our public repos are split from just a few monorepos. This usually means directly merging external contributions is a bit harder for us, so typically our developer assigned to the task will manually port it into our monorepo to let the release process publish it again. However, in this case, docker-sdk is not part of a monorepo and it would have been possible to accept your commit. Because this repo is not very typical for our workflow it was just not expected to be the way to get the job done.
Sorry about that, and we're working on improving the contribution process.
from docker-sdk.
Related Issues (20)
- Section demodata is hard-coded, impossible to use meaningful name instead HOT 4
- Key `sections` is not explained for installation recipes HOT 2
- Docker SDK sets wrong xDebug host ip environment variable when using WSL 2 HOT 3
- GitHub Action - service "cli" is not running container #1 HOT 7
- Missing SPRYKER_FE_HOST & SPRYKER_FE_PORT in glue-storefront HOT 2
- docker/sdk reset command fails to run transfer:generate HOT 1
- On Linux systems 'docker-compose' is not found when 'docker compose' is installed HOT 2
- Cannot install Spryker using Docker SDK HOT 3
- Docker external cache sources HOT 1
- Wrong NodeJS version with debian plattform image (image.node.version is ignored) HOT 4
- Sporadical WebDriver timeout in acceptance tests HOT 5
- service "cli" is not running container HOT 3
- Allow passing custom environment variables through sdk HOT 2
- Adding custom services HOT 7
- bin/service/database/mysql.sh: line 48: [: : integer expression expected HOT 2
- Allow for JSON environment variables
- failed to get console during docker/sdk up HOT 1
- bash shebang is not platform agnostic
- Reduce verbosity of `composer install` in `application-production-dependencies` stage
- Mount files db in RAM
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docker-sdk.