Code Monkey home page Code Monkey logo

Comments (11)

bnasslahsen avatar bnasslahsen commented on May 31, 2024

Hi @randyhbh,

The contribution guidelines are available here:

from springdoc-openapi-maven-plugin.

patpatpat123 avatar patpatpat123 commented on May 31, 2024

Hello @randyhbh

Thank you for this initiative.
Our team is having the same requirement.
We just want to have two outputs, (one is a directory under target that will be generated and one in a dedicated folder for history tracking).
Could you please show some example on how to do this?

Maybe some kind of comma separated? /../../docs/openapi3,${project.build.directory}

Thank you for your help

from springdoc-openapi-maven-plugin.

randyhbh avatar randyhbh commented on May 31, 2024

Hi @patpatpat123, sure I could re-open this PR or create a new one with these changes if this is a useful feature for the community.
The reason why I closed it in the first place was that usually, this is is a rare use case.

@bnasslahsen What do you think?

from springdoc-openapi-maven-plugin.

bnasslahsen avatar bnasslahsen commented on May 31, 2024

@randyhbh,

You can propose a PR ofc, if its useful for the community.

from springdoc-openapi-maven-plugin.

patpatpat123 avatar patpatpat123 commented on May 31, 2024

Many thanks @randyhbh @bnasslahsen, looking forward to seeing this!

from springdoc-openapi-maven-plugin.

anthropaedic avatar anthropaedic commented on May 31, 2024

@patpatpat123 @randyhbh @bnasslahsen

Instead of comma separated values wouldn't we want something like this?

<configuration>
	<outputFileName>myapi.json</outputFileName>
	<outputDirs>
		<outputDir>${project.build.directory}</outputDir>
		<outputDir>${project.build.directory}/testDir</outputDir>
	</outputDirs>
</configuration>

from springdoc-openapi-maven-plugin.

bnasslahsen avatar bnasslahsen commented on May 31, 2024

@anthropaedic,

You can just use maven-antrun-plugin after springdoc-openapi-maven-plugin, to copy the generated resources in your desired output directories.

from springdoc-openapi-maven-plugin.

patpatpat123 avatar patpatpat123 commented on May 31, 2024

@bnasslahsen @anthropaedic
Would it be possible not to close?

<configuration>
	<outputFileName>myapi.json</outputFileName>
	<outputDirs>
		<outputDir>${project.build.directory}</outputDir>
		<outputDir>${project.build.directory}/testDir</outputDir>
	</outputDirs>
</configuration>

This looks very clean, instead of having to "just use maven-antrun-plugin after springdoc-openapi-maven-plugin"

from springdoc-openapi-maven-plugin.

patpatpat123 avatar patpatpat123 commented on May 31, 2024

@bnasslahsen
But it is achieving it in a rather unfriendly manner.

"maven-antrun-plugin after springdoc-openapi-maven-plugin", Well, I also have a shell job that does a CP command, "it does the job" (and faster than ant)
Would it be possible to have a more objective judgement on your close? While it is true there are many ways to achieve the same result, having more descriptive, self explanatory, proper configuration directly on the maven plugin block without extra steps during or after generation might be worth considering.

Thank you

from springdoc-openapi-maven-plugin.

bnasslahsen avatar bnasslahsen commented on May 31, 2024

@patpatpat123 ,

The maven-antrun-plugin exists for decades and is very stable. Not sure you will find a much cleaner that it.
But for the moment, it doesn't seem relevant, to keep track of this ticket for several months, especially that there are other existing solutions for this kind of functionalities.

Anyway, if you come up with a much cleaner solution, please feel free to propose a PR, and the ticket can be reopened.

from springdoc-openapi-maven-plugin.

patpatpat123 avatar patpatpat123 commented on May 31, 2024

@bnasslahsen
Still believe (personal opinion)

<outputDirs>
		<outputDir>${project.build.directory}</outputDir>
		<outputDir>${project.build.directory}/testDir</outputDir>
	</outputDirs>

is a bit nicer. But maybe you and I shouldn't take the whole decision.

Meanwhile, I will stick with the shell cp command, much older than ant and "does the job" that can be done from the plugin.

from springdoc-openapi-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.