Code Monkey home page Code Monkey logo

Comments (3)

kdvolder avatar kdvolder commented on May 16, 2024

Looks like the readme and the actual patterns configured in package.json do not match.

See: https://github.com/spring-projects/sts4/blob/master/vscode-extensions/vscode-concourse/package.json#L54

        "filenamePatterns": [
          "*task*.yml",
          "**/tasks/*.yml"
        ],

Published version on marketplace is slightly different:

				"filenamePatterns": [
					"*task*.yml",
					"**/tasks/*.yml"
				],

I guess we can fix this issue by updating the readme, or by updating the default patterns themselves.

Unfortunately there seem to be a number of different ways folks name and organize their task files so likely any default set of patterns we come up with will be wrong for some folks out there.

Luckily vscode allows you to easily override these patterns in your own user or workspace settings. (There's some explanation about this in the readme too).

Also I think the patterns currently in master are slightly more selective than the ones in 0.0.8 and, I don't think they would have caused you grief as your file ending in 'Tasks.yml' no longer matches the pattern (only file ending in "task.yml" would match now.

So I think I'll opt with updating the readme to align with the patterns in master. Feel free to disagree and try and convince me otherwise.

from sts4.

chrispat avatar chrispat commented on May 16, 2024

If you go with the even more selective *task.yml I think that will be ok.

from sts4.

kdvolder avatar kdvolder commented on May 16, 2024

So yeah, I made the pattern a bit more selective "*task.yml" and updated the readme. Thanks for the feedback :-)

from sts4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.