Make the default LeaseStrategy configurable and default to retainOnIOException for more resilient applications about spring-vault HOT 3 CLOSED

Have you seen SecretLeaseContainer.setLeaseStrategy(…)?

Generally, retrying at the lease container level isn't in particular a great idea as retries belong into an infrastructure abstraction such as the HTTP Client or Spring's ClientHttpRequest.

Also, Apache's HTTP Client has a facility to retry on I/O exceptions or status codes which gives much more control over retries than trying to rebuild something in Spring Vault that actually belongs somewhere else.

from spring-vault.

Have you seen SecretLeaseContainer.setLeaseStrategy(…)?

I have but we rely on autoconfig from spring boot, we don't actually have any code calling into vault (https://docs.spring.io/spring-cloud-vault/docs/current/reference/html/#vault-lease-renewal), so unless it's exposed as a property, we can't really use it.

I realise now that this might have been better filed against https://github.com/spring-cloud/spring-cloud-vault/ which contains spring-cloud-starter-vault-config.

from spring-vault.

Alright, thank you. Indeed, Spring Cloud Vault is the place to introduce properties to pick up configuration details from config flags.

from spring-vault.