Essentially with gradle 8.6 we get: <p dir="auto"

Turned out to be this gradle stuff copied from boot <a href="https:/

Upgrade gradle 8.6 about spring-statemachine HOT 5 CLOSED

jvalkeal commented on May 29, 2024

Upgrade gradle 8.6

from spring-statemachine.

Comments (5)

jvalkeal commented on May 29, 2024

Reopen as we probably need to revert back to gradle 7.6.x due to weird issues with signing plugin.

from spring-statemachine.

jvalkeal commented on May 29, 2024

Essentially with gradle 8.6 we get:

Note, you need env variables ORG_GRADLE_PROJECT_signingKey and ORG_GRADLE_PROJECT_signingPassword to point to valid credentials for signing attempt to happen.

> Task :spring-statemachine-core:signMavenJavaPublication FAILED

FAILURE: Build failed with an exception.

* What went wrong:
A problem was found with the configuration of task ':spring-statemachine-core:signMavenJavaPublication' (type 'Sign').
  - In plugin 'org.gradle.plugins.signing.SigningPlugin$Inject' type 'org.gradle.plugins.signing.Sign' property 'generatorsByKey./home/jvalkealahti/repos/spring/spring-statemachine/main/spring-statemachine-core/build/classes/java/main.toSign' file '/home/jvalkealahti/repos/spring/spring-statemachine/main/spring-statemachine-core/build/classes/java/main' is not a file.
    
    Reason: Expected an input to be a file but it was a directory.
    
    Possible solutions:
      1. Use a file as an input.
      2. Declare the input as a directory instead.

When looking older gradle versions 8.2 is a first one to show this issue. 8.1 was still ok. Signing logic in buildSrc was copied from spring-security which is using 8.6 without issues meaning it's something else in a statemachine build causing it.

from spring-statemachine.

jvalkeal commented on May 29, 2024

When trying to debug behaviour I noticed that modifying:

spring-statemachine/buildSrc/src/main/java/org/springframework/statemachine/gradle/SpringSigningPlugin.java

Lines 63 to 67 in 451f12a

    
           public void execute(PublishAllJavaComponentsPlugin publishingPlugin) { 
        
           	PublishingExtension publishing = project.getExtensions().findByType(PublishingExtension.class); 
        
           	Publication maven = publishing.getPublications().getByName("mavenJava"); 
        
           	signing.sign(maven); 
        
           }

Just by adding call to getPublishableArtifacts() in a DefaultMavenPublication makes this issue go away. Internally it calls DefaultMavenPublication.populateFromComponent() which does something.

public void execute(PublishAllJavaComponentsPlugin publishingPlugin) {
	PublishingExtension publishing = project.getExtensions().findByType(PublishingExtension.class);
	Publication maven = publishing.getPublications().getByName("mavenJava");
	if (maven instanceof DefaultMavenPublication p) {
		PublicationArtifactSet<MavenArtifact> publishableArtifacts = p.getPublishableArtifacts();
	}
	signing.sign(maven);
}

from spring-statemachine.

jvalkeal commented on May 29, 2024

This test key was created by gpg --output public.pgp --armor --export [email protected] with password passwordD1

from spring-statemachine.

jvalkeal commented on May 29, 2024

Turned out to be this gradle stuff copied from boot

https://github.com/spring-projects/spring-boot/blob/62f922369d2714847f8e0f559e282f62d8eac63d/buildSrc/src/main/java/org/springframework/boot/build/MavenPublishingConventions.java#L117-L126

from spring-statemachine.

Upgrade gradle 8.6 about spring-statemachine HOT 5 CLOSED

Comments (5)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	public void execute(PublishAllJavaComponentsPlugin publishingPlugin) {
	PublishingExtension publishing = project.getExtensions().findByType(PublishingExtension.class);
	Publication maven = publishing.getPublications().getByName("mavenJava");
	signing.sign(maven);
	}