@Retryable won't work as expected with exclude about spring-retry HOT 8 CLOSED

Fixed in #108

from spring-retry.

My interpretation is that only when both exclude and include are missing it retries all exceptions.

That's what the javadoc says

/**
 * Exception types that are retryable. Synonym for includes(). Defaults to empty (and
 * if excludes is also empty all exceptions are retried).
 * @return exception types to retry
 */
Class<? extends Throwable>[] value() default {};

/**
 * Exception types that are retryable. Defaults to empty (and if excludes is also
 * empty all exceptions are retried).
 * @return exception types to retry
 */
Class<? extends Throwable>[] include() default {};

/**
 * Exception types that are not retryable. Defaults to empty (and if includes is also
 * empty all exceptions are retried).
 * @return exception types to retry
 */
Class<? extends Throwable>[] exclude() default {};

The SimpleRetryPolicy now supports an "all except" option, but it's not currently supported via the annotation.

from spring-retry.

You can, of course, use

@Retryable(include = RuntimeException.class, exclude = IllegalArgumentException.class)

from spring-retry.

I get all that, but why not

@retryable(exclude = IllegalArgumentException.class) and include by default any other exception, is there a technical limitation of doing this?

from spring-retry.

No, there's no technical reason, it's just the way it was implemented.

from spring-retry.

I guess this is not a bug but an enhancement request.

from spring-retry.

Is this already fixed?
Im using spring-retry 1.1.2.RELEASE with Spring boot 1.5.10.RELEASE
and not reproduce.

from spring-retry.

What the purpose of exclude option, if any exception is also excluded by default when exclude is not empty?

So

@Retryable(exclude = IllegalArgumentException.class)

actualy excludes ALL exceptions, not just IllegalArgumentException.

I think this is very confusing behavior.

I understand that it could be a breaking change, but current behavior has no sense. It works as expected (expected not from documentation perspective, but from common sense perspective) only when include = Throwable.class is also present.

Maybe consider this change for 2.0, if you think this would be too breaking change for 1.x.

from spring-retry.