Code Monkey home page Code Monkey logo

Comments (3)

malex211 avatar malex211 commented on May 22, 2024 11

I think this is because Spring Retry uses Spring AOP and the methods are intercepted only when they are called from outside the bean (because of the proxy-based nature of Spring AOP). So for example this should work:

@Component
public class UserInfoFetcher {

   @Retryable(NetworkIOException.class)
   public UserInfo fetchUserInfo(Long id) {
       //client.get(http://xxxx)
   }
}
@Service
public class UserService {
    
    @Autowired
    private UserInfoFetcher userInfoFetcher;

    pubilc getUser(Long id) { 
        userInfoFetcher.fetchUserInfo(id);
    }
}

from spring-retry.

antergone avatar antergone commented on May 22, 2024 1

fixed!
but it's bad code!

@Service
public class UserService {

   @Autowired
   UserService userService;

   @Retryable(NetworkIOException.class)
    pubilc getUser(Long id) { 
        Strign serial = dal.getSerialById;
        userService.fetchUserInfo(serial);
    }

   private UserInfo fetchUserInfo(String serial) {
       //client.get(http://xxxx/:serial)
   }
}

from spring-retry.

dsyer avatar dsyer commented on May 22, 2024

I don't see the difference. If there is a NetworkIOException you call fetchUserInfo() up to 3 times in both cases.

from spring-retry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.