RetryListener can't easily determine if the retry will be retried or not about spring-retry HOT 3 CLOSED

Sorry for the delay in replying.

We could probably make such a change in a major or minor release (e.g. 1.2.0), but not in a point release (1.1.3) because it's a behavior change and someone might be relying on the existing behavior with respect to the state of the context when onError is called (small probability, perhaps, but non-zero).

One work-around might be to defer your ERROR log to the close() which is called after the context has been updated and before the exception is actually thrown to the caller. Note that, if needed, you can add/modify custom context attributes in the listener methods.

from spring-retry.

The listener contract is a bit bizarre for historical reasons (sorry). We should look at it for 1.2 or 2.0. In the meantime there is a StatisticsListener that does a lot of heavy lifting analysing the actual state of the policy and relaying it into stats. Maybe you can use that or copy bits of it?

from spring-retry.

This commit has made a change requested in this issue as a side effect of other premise.
So, since the current code is like this:

					try {
						registerThrowable(retryPolicy, state, context, e);
					}
					catch (Exception ex) {
						throw new TerminatedRetryException("Could not register throwable", ex);
					}
					finally {
						doOnErrorInterceptors(retryCallback, context, e);
					}

I treat this issue as Fixed.

from spring-retry.