How to run VisitsViewTest from command line about spring-petclinic HOT 5 CLOSED

VisitsViewTest should be renamed to VisitsViewTests (or the POM should be modified to include **/*Test.java), and the XML configuration file should reside under the test resources folder, in line with Maven's standard directory structure (i.e., src/test/resources/org/springframework/samples/petclinic/web/VisitsViewTests-config.xml (assuming the test class was renamed)).

from spring-petclinic.

Thanks Sam! Thats very helpful.

from spring-petclinic.

I've made the changes accordingly. That's for spotting that issue!
I haven't moved the config file to the resources folder because it makes it a bit harder to find. So I've changed the POM so VisitsViewTests-config.xml can be loaded even though it's inside src/test/java

from spring-petclinic.

Is there a reason you're not using Spring's LocalValidatorFactoryBean?

Also, using the TestContext framework to load an ApplicationContext just to instantiate a validator is a bit of overkill. So why not make this an actual unit test like this?

public class ValidatorTests {

  private Validator createValidator() {
      LocalValidatorFactoryBean localValidatorFactoryBean = new LocalValidatorFactoryBean();
      localValidatorFactoryBean.afterPropertiesSet();
      return localValidatorFactoryBean;
  }

  @Test
  public void emptyFirstName() {
      Validator validator = createValidator();
      // ...
  }
}

from spring-petclinic.

Thanks Sam! I've made changes accordingly.

from spring-petclinic.