CouchbaseTemplate#findByView is always including documents in ViewResponse. [DATACOUCH-28] about spring-data-couchbase HOT 5 CLOSED

David Harrigan commented

Hi,

My 2C's:

Perhaps we should trust the developer to "do the right thing" (tm) :-). Instead of forcing the query to include the docs, let's rely on the developer to set the "willIncludeDocs" if they want docs, otherwise it's their fault if they don't set this attribute and no docs are returned.

I would imagine that with a bit of clear JavaDoc and the expectation that the Developer understands the basic query API, they will realise that if they want docs, they must set this value.

-=david=-

from spring-data-couchbase.

Michael Nitschinger commented

makes sense guys.. I originally had that in to aid my repository implementation, but since it's causing issues I'll make that better. looking forward to add it in M2

from spring-data-couchbase.

David Harrigan commented

#7 created.

Just a bit unsure about SimpleCouchbaseRepository, is it okay to setIncludeDocs(true) at line 122?

-=david=-

from spring-data-couchbase.

David Harrigan commented

Updated pull request based upon Michael's kind feedback.

#8

-=david=-

from spring-data-couchbase.

Michael Nitschinger commented

Note that after discussion and thought, this won't be fixed. Here's the reason (copied from the github conv):

@dharrigan I looked at this once more in the codebase and I know remember why I did it originally. Let's talk it through so we got an the same line..

in the findByView, I get a list of marshalled objects back, but when setIncludeDocs is not set to true always the method won't return useful data (because I have nothing to marshal from).

If you look down further, there is the queryView method which lets you access the query result directly (while still getting the exception mapping).

That's also why I force reduce to false because if you have a reduced view I can't get the object ids from the result

from spring-data-couchbase.