StackOverflowError on self-referencing Objects [DATACMNS-38] about spring-data-commons HOT 5 CLOSED

Robert Stiller commented

I've forgot the siteService:

package example.service;

import org.springframework.data.document.mongodb.repository.MongoRepository;
import org.springframework.data.document.mongodb.repository.QueryDslPredicateExecutor;

import example.Site;

public interface SiteService extends MongoRepository<Site, String>, QueryDslPredicateExecutor<Site> {
}

from spring-data-commons.

Oliver Drotbohm commented

That should have been fixed with 54ada02. Could you please try a current snapshot?

from spring-data-commons.

Robert Stiller commented

I figured out, that i did not specify a "collection" attribute in the @DBRef annotation.
It still does not work without it:

@Document(collection = "sites") //Doesn't work without the collection specified too
class Site {
    ...
    @DBRef
    protected Site parent;
    ...
}

But... if I specify the correct collection it works:

@Document(collection = "sites")
class Site {
    ...
    @DBRef(collection = "sites")
    protected Site parent;
    ...
}

I thought, that the object/class itself would be enough for @DBRef to figure out the correct collection.
So this may be a future feature :D

You should refer this issue in the documentation or try to figure out the correct collection using the class of the field annotated - if not explicitly specified (don't forgot a debug-log-message for automatically determined collections)

from spring-data-commons.

Robert Stiller commented

I've got another issue:

public class MyObject {
  ...
  protected Map<String, Attribute> attributes = new HashMap<String, Attribute>();
  ...
}

public class Attribute {
  ...
  protected String name;
  protected String value;
  protected Map<String, Attribute> children = new HashMap<String, Attribute>();
  ...
}

This causes the introspection to be terminated by a StackOverflowError, too.

You may fix it by breaking introspection on fields with a type(class) already introspected or now being introspected in the responsible method ...

One should also prevent endless loops caused by circular references. A detection with the corresponding Exception would be fine

from spring-data-commons.

Oliver Drotbohm commented

I've tweaked the algorithm of AbstractMappingContext a little so that it should now recognized already added PersistentEntity instances on recursive invocations. Made some refactorings in the TypeInformation part as well and added further tests to cover additional cases. Hope this one finally solves it for you (and us ;) )

from spring-data-commons.