Change log4j and slf4j-log4j12 maven dependencies scope [DATACMNS-14] about spring-data-commons HOT 5 CLOSED

Stevo Slavić commented

+1

For spring framework modules, logging implementation, log4j, is marked as compile scope optional dependency. Related ticket: SPR-5327

from spring-data-commons.

Pablo Alcaraz commented

In my case, I am using slf4j + logback

I had to put a weird exclusion in my pom.xml to wipe slf4j-log4j12

<dependency>
<groupId>org.springframework.data</groupId>
<artifactId>spring-data-commons-core</artifactId>
<version>1.0.0.M3</version>
<exclusions>
     <exclusion>
          <groupId>org.slf4j</groupId>
          <artifactId>slf4j-log4j12</artifactId>
     </exclusion>
</exclusions>

I think we have to follow the SLF4J facade recommendation. Extracted from SLF4J Manual:

As of SLF4J version 1.6.0, if no binding is found on the class path, then slf4j-api will default to a no-operation implementation discarding all log requests. Thus, instead of throwing a NoClassDefFoundError because the org.slf4j.impl.StaticLoggerBinder class is missing, SLF4J version 1.6.0 and later will emit a single warning message about the absence of a binding and proceed to discard all log requests without further protest. For example, let Wombat be some biology-related framework depending on SLF4J for logging. In order to avoid imposing a logging framework on the end-user, Wombat's distribution includes slf4j-api.jar but no binding. Even in the absence of any SLF4J binding on the class path, Wombat's distribution will still work out-of-the-box, and without requiring the end-user to download a binding from SLF4J's web-site. Only when the end-user decides to enable logging will she need to install the SLF4J binding corresponding to the logging framework chosen by the end-user.

from spring-data-commons.

Oliver Drotbohm commented

Reduced scope of all but the SLF4J API module to test scope which should then resolve yll off the issues you mentioned. Feel free to give it a try and report back if you still face problems

from spring-data-commons.

Oliver Drotbohm commented

Log4J dependency is still in runtime scope due to reverted fix inside a merge commit

from spring-data-commons.

Oliver Drotbohm commented

Should be fixed by Jon's latest commit that makes us using Commons Logging again

from spring-data-commons.