Cache result of `RepositoryInformationSupport.getQueryMethods()` about spring-data-commons HOT 5 CLOSED

This should be all in place now.

from spring-data-commons.

Thank you @dodgex for raising the issue. Let me take this to the team.

from spring-data-commons.

Thanks for bringing this up. I've introduced a cache for the query methods and the information calculated in RepositoryInformation. Would you mind giving the latest snapshots a spin? If those look good, I'd back-port the fix back into the maintenance branches.

from spring-data-commons.

@odrotbohm I gave your changes a quick try. The application started as "quickly" as with my hacky solution, and as far as I tested everything worked!

And as expected your implementation is a bit cleaner than mine. ;)

I found that your polishing commit got a typo in interfacse.
Also I'm curious if it is intended to have the calculateQueryMethods and calculateHasCustomMethod methods private final instead of just private. And the queryMethods field is Lazy<> while the other two are Supplier<> although all three of them come from Lazy.of().

Thanks for the quick fix.

from spring-data-commons.

Great feedback, thanks! We tend to use private final for methods being invoked from constructors, but it's a cosmetical change. You're right that we can switch the field declaration to a Supplier as we don't need any Lazy-specific methods here.

I'll apply those fixes and backport the changes.

from spring-data-commons.