Code Monkey home page Code Monkey logo

Comments (3)

wilkinsona avatar wilkinsona commented on July 22, 2024

This due to a few mistakes in your configuration. I've forked the sample and pushed a commit with comments describing the changes that need to be made and why.

from spring-boot.

rujche avatar rujche commented on July 22, 2024

Hi, @wilkinsona

Thank you for your quick response and detailed explanation. 2 points still confused me: (Problem solved.)
1. As I commented in your commit, I didn't understand why all of the nested conditions use the parse configuration phase.
2. When using @Import annotation, @ConditionalOnClass and AllNestedConditions have same behavior. But when using META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports, they behave different. I updated the sample project, please take a look: https://github.com/rujche/problem-reproduce/tree/ConditionalOnClass-not-work-as-expected-when-added-in-AllNestedConditions

from spring-boot.

rujche avatar rujche commented on July 22, 2024

Hi, @wilkinsona

Thank you for your quick response and detailed explanation. 2 points still confused me:

  1. As I commented in your commit, I didn't understand why all of the nested conditions use the parse configuration phase.
  2. When using @Import annotation, @ConditionalOnClass and AllNestedConditions have same behavior. But when using META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports, they behave different. I updated the sample project, please take a look: https://github.com/rujche/problem-reproduce/tree/ConditionalOnClass-not-work-as-expected-when-added-in-AllNestedConditions

Update:

  1. About point 1, I already got the answer.
  2. About point 2, I updated the sample to Use PARSE_CONFIGURATION to make FirstAutoConfiguration and SecondAutoConfiguration have same behavior. Thank you all the same.

from spring-boot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.