Prometheus Exemplars are missing from _count about spring-boot HOT 5 CLOSED

Hello Jonatan,

for 1: fromPropertiesMap is used in

public Properties prometheusProperties() {
  return get(this::fromPropertiesMap, PrometheusConfig.super::prometheusProperties);
}

and this get method does this:

protected final <V> V get(Function<T, V> getter, Supplier<V> fallback) {
  V value = getter.apply(this.properties);
  return (value != null) ? value : fallback.get();
}

So if getter returns null, it invokes fallback.

With our invocation, if fromPropertiesMap returns null, it uses super.prometheusProperties().

Looking at fromPropertiesMap:

Map<String, String> map = prometheusProperties.getProperties();
if (map.isEmpty()) {
  return null;
}

So if there are no user-defined properties, we return null, and get will use super.prometheusProperties().

This looks fine to me, or have I overlooked something?

from spring-boot.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

from spring-boot.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.

from spring-boot.

The bot reminded me that there's something pending. I gave it another look, and it looks like that point 1 that @jonatan-ivanov has raised isn't valid, but the 2nd is.

I have something in https://github.com/mhalbritter/spring-boot/tree/mh/40904-prometheus-exemplars-are-missing-from-_count, but I need to play around with it a bit more.

from spring-boot.

I also added a smoke test to verify that it doesn't break in the future.

from spring-boot.