Factor out common file handling concerns of Xml and FlatFile output templates [BATCH-16] about spring-batch HOT 10 CLOSED

Dave Syer commented

Can't fix this until the contents of Xml package are finalised (BATCH-113).

from spring-batch.

Lucas Ward commented

This is fixed in the StexEventWriterOutputSource, but not in the FlatFileOutputSource, once FileUtils is used in the later, this issue can be closed.

from spring-batch.

Peter Zozom commented

Refactored FlatFileOutputSources (single and splittable), which were attached to issue BATCH-34 now uses FileUtils.

from spring-batch.

nebhale commented

Has this been sorted?

from spring-batch.

Dave Syer commented

To a large extent. There is a FileUtils now that was created in response to this issue (it was never closed because you can always do more). I'm happy to resolve this against 1.0.

from spring-batch.

Lucas Ward commented

I hasn't really been resolved, not everything uses the FileUtils, and it's not really generic in the original intent of the issue. The problem is that if you wanted to do something like BATCH-34. If I wanted to work with an ItemReader or ItemWriter that required a file generically I can't. It's not a huge deal, it just means you would need ItemReader or writer specific abstractions to wrap it. It would mean a bit of code duplication and some weirdness but not the end of the world. No way to change this for release 1 though, it will have to be a 1.1 thing.

from spring-batch.

nebhale commented

Sounds good.

from spring-batch.

Lucas Ward commented

Robert, I think you've solved some of this issue with your work on the MultiResourceItemReader.

from spring-batch.

Robert Kasanicky commented

Both FlatFileItemWriter and StaxEventItemWriter now use FileUtils so consistency is achieved. If we want to do something more it will be better to track it in a fresh issue.

from spring-batch.

Dave Syer commented

Assume closed as resolved and released

from spring-batch.