Code Monkey home page Code Monkey logo

Comments (19)

re6exp avatar re6exp commented on May 18, 2024 3

I'm working on filters that rewrite request/response body.

Now they successfully work with string body, url encoded, json objects.

In plans to add support of multipart/form-data and sse post-processing to complete the set of data conversions how it has been done in Spring Webflux handlers concerning codecs and readers/writers.

See comment.

Have you interest?

from spring-cloud-gateway.

re6exp avatar re6exp commented on May 18, 2024 2

@spencergibb
Ok, after I will finish text-stream-based response rewritting, I'm going to prepare code to PR and release it. At the moment I have to deepen my Flux knowledge to solve it - I'm being in reading docs... After this, the form-multipart rewritting remains, I hope I will also do it. The progress can be viewed here. Any comments or suggestions are welcome.

from spring-cloud-gateway.

checketts avatar checketts commented on May 18, 2024 1

I'm working with Rate limiters too via filters. I really want to have the 3 prong approach we see here: https://stripe.com/blog/rate-limiters working with a Spring Cloud project.

from spring-cloud-gateway.

sbartram avatar sbartram commented on May 18, 2024 1

I have a concurrent request rate limiter implemented on Redis using the same model as RedisRateLimiter and the Stripe rate limiters. Before I spend time prepping the code for a pull request, I'd like to know if there is interest?

Thanks

from spring-cloud-gateway.

spencergibb avatar spencergibb commented on May 18, 2024

See 0105e57 for sample token-bucket filter.

from spring-cloud-gateway.

spencergibb avatar spencergibb commented on May 18, 2024

I'll take a look

from spring-cloud-gateway.

spencergibb avatar spencergibb commented on May 18, 2024

Nice, lots of code too!

from spring-cloud-gateway.

spencergibb avatar spencergibb commented on May 18, 2024

@checketts check out 34e6366.

from spring-cloud-gateway.

checketts avatar checketts commented on May 18, 2024

Wow that looks very clean with good potential for extensibility eventually. The Lua part scares me a bit since I don't understand how that integrates or changes the atomicity of the redis call.

I've been trying to reason through a non-redis implementation, likely Memcached. Would porting the Lua code into Java client code be sufficient?

from spring-cloud-gateway.

spencergibb avatar spencergibb commented on May 18, 2024

https://redis.io/commands/eval#atomicity-of-scripts

I like that this is run in production at stripe.

from spring-cloud-gateway.

mdiskin avatar mdiskin commented on May 18, 2024

Looking to migrate off our commercial gateway (CA). Main features we use today are for SOAP services would there be anything to re-implement those:

  • Require/Add WS-Security Signature, Signed Timestamp/Element
  • Evalute XPATH, XSLT
  • Protect against Message Reply

We use SpringWS but these were not extensively supported but possible in the WSS4j side. Looking if it's an easy switch over to CXF (3.2) that supports Spring Boot.

from spring-cloud-gateway.

spencergibb avatar spencergibb commented on May 18, 2024

@sbartram if you're talking about the "Concurrent Request Rate Limiter" from https://stripe.com/blog/rate-limiters, then yes, there is interest.

from spring-cloud-gateway.

spencergibb avatar spencergibb commented on May 18, 2024

@re6exp yes, PRs welcome

from spring-cloud-gateway.

dragontree101 avatar dragontree101 commented on May 18, 2024

i also want to rewrite request/response body, hold can pr to spring-cloud-gateway .
thanks

from spring-cloud-gateway.

spencergibb avatar spencergibb commented on May 18, 2024

@re6exp wow, that is major complex. I hope that is not what is ultimately needed. If it is, it will be a separate optional module.

from spring-cloud-gateway.

ninja-panda avatar ninja-panda commented on May 18, 2024

Hi All, Is Request Size limiting is available ?

from spring-cloud-gateway.

domainname avatar domainname commented on May 18, 2024

How about Set Response Content filter? I would love to see it on the list.

from spring-cloud-gateway.

re6exp avatar re6exp commented on May 18, 2024

@spencergibb @domainname
Here are some blocked changes that can be useful.

from spring-cloud-gateway.

spencergibb avatar spencergibb commented on May 18, 2024

Closing. Let's track filters individually now. Please open new issues.

from spring-cloud-gateway.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.