Code Monkey home page Code Monkey logo

Comments (5)

mrbrdo avatar mrbrdo commented on May 29, 2024

@wjwitek

from spree.

wjwitek avatar wjwitek commented on May 29, 2024

Hi, if you would like to make a PR, I think adding alias 'try_spree_current_user' to a method that fetches a user in spree_api_v1 would make sense.
That being said, spree_api_v1 is deprecated and it's possible it won't be compatible with future spree versions.

from spree.

mrbrdo avatar mrbrdo commented on May 29, 2024

@wjwitek thanks for the answer. After looking at this more, I am not sure if spree_rails_frontend is even using api v1 anymore. Do you know? I think in the past it did use it, but after checking with v4.7, I can't find if it's still used.

from spree.

wjwitek avatar wjwitek commented on May 29, 2024

@mrbrdo, I'm not sure, but spree_api_v1 is not a dependency of spree_rails_frontend so I guess it doesn't use it.

from spree.

mrbrdo avatar mrbrdo commented on May 29, 2024

Ok thanks. I guess this is an issue of spree_api_v1 then.

from spree.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.