Memory Leak in Annoy (get_nns_by_vector)? about annoy HOT 8 CLOSED

It also exists in .get_nns_by_item() but looks like it does not exist in annoy==1.16.3

from annoy.

Interesting! I'm surprised this happens since none of that code has been touched for years and it feels like it should have been discovered a long time ago. Do you have any more information that's relevant, like what Python version and what OS you're using?

from annoy.

Yes, very surprising!
Tested on a bunch of Debian VMs with 3+ GB of RAM: Debian GNU/Linux 11 (Bullseye), Python 3.9.16
(garden variety VM from GCP).

from annoy.

Also:

$ uname -r
5.10.0-21-cloud-amd64

and

$ pip3 freeze | fgrep annoy
annoy==1.17.1

from annoy.

I can confirm the data leak on my end also

$ uname -r
5.4.0-146-generic

Same library version. Downgrading to 1.16.3 also fixed for me.

from annoy.

@siva-tonita @wyolland @SteliosGian would you mind running this against latest main to see if there's still a memory leak?

I haven't been able to reproduce the issue, but I'm fairly sure there was a missing Py_XDECREF with include_distances=True

If the issue is gone, I'll release 1.17.2

from annoy.

@erikbern looks like the issue is resolved when i install from main

from annoy.

amazing – will release a new version

from annoy.