Missing dependency for Assert in 3.0.0 about lexik-jose-bridge HOT 7 CLOSED

Thanks for this issue.
A patch will be submitted soon on both v3.0 and v2.2 branches

from lexik-jose-bridge.

I've created a PR #51 to fix this issue. Basically I removed 2 lines of code with Assertion class since, I believe, it was introduced accidentally

from lexik-jose-bridge.

Looks like this bug can be closed, right?

from lexik-jose-bridge.

Hi @Spomky !

It seems that the tagged version v3.0.0 is still with the issue.
I think you need to upgrade the version to a newer tag to have @tereschenkov 's fix.

from lexik-jose-bridge.

Hi @Djamy,

Thank you for your patience. I’ve just push a fix for that issue.
This should work fine now. Waiting for CI to finish.

from lexik-jose-bridge.

Thank you @Spomky it seems to work so far!

I'm just curious here, could you tell me why you choose to import native PHP function here?
Is there a specific reason or something?

from lexik-jose-bridge.

Thank you @Spomky it seems to work so far!

Great. I close the issue now. Feel free to open it if something went wrong with the last modifications.

I'm just curious here, could you tell me why you choose to import native PHP function here?
Is there a specific reason or something?

\is_string is a micro-optimization. Php-CS-Fixer is able to import all there function and from my POV it looks easier to read.
In addition, when contributors modify the files, they don't have to brother with this optimization.

from lexik-jose-bridge.