Comments (1)
Yes! I'm having the same problem :/
I use "scp" and have a block that says something like "if scp returns an err, print it and callback", but the function keeps going instead of exiting and is causing node to crash.
If I give it a hostname that works, this code works great! But if the path doesn't exist, it fails with:
TypeError: Cannot read property 'createReadStream' of undefined
at .../app/node_modules/scp2/lib/client.js:282:31
I'll insert more code:
scp.scp({
host: 'somehost',
username: 'myusername',
password: 'mypassword',
path: 'somepath'
}, './', function(err) {
console.log(err);
callback(err); //the code doesn't stop here, though!
});
I was able to fix this by changing this code:
Client.prototype.download = function(src, dest, callback) {
var self = this;
self.sftp(function(err,sftp){
var sftp_readStream = sftp.createReadStream(src);
sftp_readStream.on('error', function(err){
callback(err);
});
sftp_readStream.pipe(fs.createWriteStream(dest))
.on('close',function(){
self.emit('read', src);
callback(null);
})
.on('error', function(err){
callback(err);
});
});
};
to this:
Client.prototype.download = function(src, dest, callback) {
var self = this;
self.sftp(function(err,sftp){
if(!err) //<---
{ //<---
var sftp_readStream = sftp.createReadStream(src);
sftp_readStream.on('error', function(err){
callback(err);
});
sftp_readStream.pipe(fs.createWriteStream(dest))
.on('close',function(){
self.emit('read', src);
callback(null);
})
.on('error', function(err){
callback(err);
});
}else //<---
{ //<---
callback(err); //<---
} //<---
});
};
I'll fork the repo and do a pull request
from node-scp2.
Related Issues (20)
- scp2 use vulnerable lodash version HOT 3
- Wrong remote path when uploading multiple files via glob pattern (issue with path.relative) HOT 2
- Callback function
- Doing SCP HOT 1
- Malformed packet
- Error: Received exit code 127 while establishing SFTP session HOT 2
- Does this library provide multiplexing option?
- windows平台无法设置上传的目录权限
- Error: Unknown message digest
- Publish SCP2 to npm HOT 1
- SFTP Connection Timeout | Retry
- Cannot parse privateKey: Unsupported key format HOT 5
- How to exclude some files or folders? HOT 4
- how to remove file. like the CleanWebpackPlugin
- lodash vulnerabilities HOT 1
- node-scp-async
- All configured authentication methods failed HOT 2
- scp2的文件上传在vscode版本: 1.53.2下无法上传文件
- Is node-scp2 implementing sftp instead of scp?
- please update packages, Loadash
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-scp2.