Comments (2)
andrehjr
commented on June 2, 2024
1
Hi @knarewski! Thanks for the issue and the repro!
Please send a PR 🎉 We should also protect it against other types. if JSON.parse returns anything other than a Hash, split wouldn't know how to handle it.
An integer would also break:
curl -H "User-Agent: not-a-bot" -H 'Cookie: split=1' localhost:4567
If I remember correctly, this issue should happens with json >= 2.0. Because the behavior of JSON.parse changed.
from split.
knarewski
commented on June 2, 2024
Hi @andrehjr ! Thank you for such a swift response 🚀 ! I prepared a fix, but it's blocked by an unrelated CI failure. I'm happy to submit a PR once the CI fix is merged: #696
from split.
Related Issues (20)
- ERR wrong number of arguments for 'hset' command HOT 6
- Improved experience in the split dashbaord
- "Insufficient confidence" with 1400+ participants, 60+ completions and 2 variants HOT 2
- Multiple tests with the same prefix (e.g. menu and menu_underline) will result in the second test being recalculated at every request HOT 4
- The control group is not always the default in RSpec tests HOT 2
- custom error tracking middleware like raygun / sentry / etc? HOT 2
- Split Dashboard showing negative NON-FINISHED value HOT 1
- Error connecting to Redis with cookie config HOT 1
- Update alternative weights dynamically
- ActionView::Template::Error (Unsupported command argument type: TrueClass) HOT 8
- Deprecation warning by using `redis.sadd` with Redis 4.8.0 HOT 5
- `matrix` should be added as a dependency
- Rubystats gem causes name conflict that won't allow Rails application to start properly HOT 1
- SSL_connect error when opening dashboard or calling ab_test() or ab_finished() since updating our Heroku redis from 5 to 7 HOT 4
- CROSSSLOT keys issue when using redis cluster HOT 5
- Assign running experiment to logged_in_user HOT 1
- Split Dashboard can take minutes to load after upgrading to Split v4.x (with RubyStats) HOT 5
- 'cleanup_old_experiments' error when running from non-web (eg. console) HOT 2
- New release with redis 4.8 compatibility ? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from split.