Comments (5)
In GitLab by @manuelma on Jan 18, 2019, 22:03
changed the description
from spine-database-api.
In GitLab by @jkiviluo on Jan 21, 2019, 11:12
There is the short style guide in https://gitlab.vtt.fi/spine/toolbox/wikis/principles
Do we need some more specific rules as well?
from spine-database-api.
In GitLab by @manuelma on Jan 21, 2019, 17:13
Those guidelines are good, we just need to be more thorough on respecting them. My opinion is that the code is not a complete mess, but some parts need to be polished and this issue is kind of a reminder for me that we need to do that.
Edit: maybe 'not a complete mess' is an understatement. I should say the code looks pretty good overall, but there are some silly style errors such as not respecting the line length limit, or some comments that were copy-pasted from other methods, but the wording was not adjusted.
from spine-database-api.
In GitLab by @manuelma on Apr 9, 2019, 02:21
We're doing our best. Closing this now...
from spine-database-api.
In GitLab by @manuelma on Apr 9, 2019, 02:21
closed
from spine-database-api.
Related Issues (20)
- Can't trust legacy tool/feature/method for compatibility transformations
- Write type information for simple types as well HOT 7
- Rollback purge HOT 1
- Add Toolbox tests to GitHub actions? HOT 3
- Parameter value format documentation is missing index_name
- Wrong results after changing a filter
- Make sure TempId travel safely across the socket (DB server)
- The tool filter only works with 1 tool activated
- No entity can pass its tool filter when there are multiple `tool_feature_method`s HOT 1
- Fix broken example in parameter_value API documentation
- Guidelines on what to import in __init__.py
- Improve parsing performance by accepting only ISO 8601 time stamps HOT 2
- Check that CHANGELOG.md is up-to-date for 0.8-dev HOT 1
- Compatibility transformation should keep working after the first time HOT 1
- Alternative filter does not filter by entity alternatives
- Trying to get a parameter value that does not exist Tracebacks
- Mention the difference between entity_byname and element_name_list in documentation HOT 2
- Support EPS Value in GDX Exporter HOT 2
- SpineDBServer as standalone application
- fix unit test test_upgrade_schema
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spine-database-api.