Code Monkey home page Code Monkey logo

Comments (14)

nadar avatar nadar commented on June 6, 2024 1

In order to test branches, packagist automatically publishes branches. you can access them by using dev-<branch-name>. So in order to test i just did "spekulatius/phpscraper": "dev-181-switch-from-goutte-to-browser-kit as 1.0.2" and composer u.

Looks good so far, will make some tests. thanks

from phpscraper.

nadar avatar nadar commented on June 6, 2024 1

@spekulatius great, thanks for taking care 👍

from phpscraper.

monsefsolutions avatar monsefsolutions commented on June 6, 2024 1

@spekulatius Thank you for the quick responses and solution!

from phpscraper.

monsefsolutions avatar monsefsolutions commented on June 6, 2024 1

from phpscraper.

nadar avatar nadar commented on June 6, 2024 1

Thanks! I just upgraded and tested to 2.0, works 👍

from phpscraper.

spekulatius avatar spekulatius commented on June 6, 2024

Hey @nadar

yeah, Goutte is more or less just a wrapper around other packages at this point. It looks as if using the original dependencies instead is the way to go. I'm pretty busy atm. Do you think you could look into this? Otherwise it will have to wait a bit.

Cheers,
Peter

from phpscraper.

monsefsolutions avatar monsefsolutions commented on June 6, 2024

First of all, thank you @spekulatius for this great scraper and all the work you put into it. I really appreciate it.

I get a similar error like @nadar mentioned when switching to PHP 8.2.6.

The "Goutte\Client" class is deprecated, use "Symfony\Component\BrowserKit\HttpBrowser" instead

I wish I could help with solving the error, but unfortunately, I'm not that familiar with Goutte and BrowserKit. I will wait patiently for the fix and in the meantime switch back to PHP 7.4.x. Again, thanks for this amazing tool.

from phpscraper.

spekulatius avatar spekulatius commented on June 6, 2024

Hello @nadar and @monsefsolutions,

I've pushed a branch called 181-switch-from-goutte-to-browser-kit to address this issue by switching the base lib. Could you clone the repo into your vendor folder and test this? Thank you!

Cheers,
Peter

from phpscraper.

monsefsolutions avatar monsefsolutions commented on June 6, 2024

Hi @spekulatius,

Thank you for your quick response, really appreciate it. I just copied the files from the new branch and I do not get any errors anymore with PHP 8.2.6 active. Thank you!

from phpscraper.

spekulatius avatar spekulatius commented on June 6, 2024

Sounds like we are on a good path. I'll check it a bit more merge it and tag a new major release (as the interface changes)

from phpscraper.

spekulatius avatar spekulatius commented on June 6, 2024

I've merged the branch and will tag a new major release once a number of smaller fixes have been included @nadar & @monsefsolutions.

from phpscraper.

spekulatius avatar spekulatius commented on June 6, 2024

Hello @nadar & @monsefsolutions

I've pushed the last changes for v2. Could you give the v2 branch a spin and see if you notice any problems before I merge and tag it? Thank you in advance!

Peter

from phpscraper.

spekulatius avatar spekulatius commented on June 6, 2024

Okay, let me know if you find any issues @monsefsolutions 👍

from phpscraper.

spekulatius avatar spekulatius commented on June 6, 2024

Hello @monsefsolutions and @nadar,

I've tagged a new major release. Feel free to give it a try and let me know if you find any issues.

Cheers,
Peter

from phpscraper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.