Code Monkey home page Code Monkey logo

Comments (13)

Aemony avatar Aemony commented on May 21, 2024 1

I'm going out on a limb and argue that the hardware of aficionados here is very much skewed towards the higher end (let alone if you consider that those reporting back are yet even a more exclusive club).
Also, even though SK is certainly a must for HDR screenshots, I'd still use steam or whatnot otherwise.

Yeah, though as Special K by default hooks the Steam screenshot feature, it would create issues even for users using the standard Steam feature if it was combined with Special K... It's partially why I am so surprised we haven't heard of it before...

Anyway, since the issue have shown itself to be elusive it'll probably be a long while before it's fully tracked down and worked around, or solved if that's even possible.

from specialk.

Aemony avatar Aemony commented on May 21, 2024

The following example was produced using The Ascent with the game running at 2100x900 in a window in D3D12 mode. No other third-party software is involved in the game session -- Nvidia Ansel had been blocked and even Steam's overlayrenderer64.dll file was denied execution prior to launching the game.

Resulting screenshot:
1657145358

Files:

Logs:

from specialk.

Aemony avatar Aemony commented on May 21, 2024

Correction: Any horizontal resolution not divisible by 32 seems to be affected by it, so it's not actually related to the aspect ratio itself.

from specialk.

Kaldaien avatar Kaldaien commented on May 21, 2024

Problem is caused by drivers not including correct stride in resource description, it's unlikely this can be fixed.

from specialk.

Aemony avatar Aemony commented on May 21, 2024

Dr. Dro was able to reproduce it on AMD hardware with a 1680x1050 resolution as well (1680%32 == 16, so not divisible by 32).

It sounds unlikely to be a driver issue affecting both vendors, but barring any other possible cause that does sound possible, unless maybe it's something in Windows itself that broke recently? 🤔

Edit: Lilium threw together some CPP code that's able to at least restore the partial corrupted data (though some data loss is unrecoverable):

from specialk.

EndlesslyFlowering avatar EndlesslyFlowering commented on May 21, 2024

here is a slightly updated version that now writes a line of black pixels instead of repeating the last useable line of pixels
also a few more comments to make it easier to understand
undoMess.zip

from specialk.

Aemony avatar Aemony commented on May 21, 2024

I've gone back all the way to v 20.12.30 and confirmed the same issue exists even on that version with The Ascent running in a window at 1680x1050 resolution on my work PC... And that's like one of the first versions that had DirectX 12 support, I think?

My work PC uses Nvidia's Quadro drivers from May, v 512.78, along with last month's Windows 10 update, so those aspects are somewhat up-to-date as well...

The data would seem to suggest that this bug has been present for the longest of times, which I find baffling to the extreme -- do we really not have more users using e.g. 1680x1050 or 1360x768/1366x768 with Special K ? Those resolutions combined are used by like ~8% of Steam's userbase.

This sure is a doozy.

from specialk.

mirh avatar mirh commented on May 21, 2024

I'm going out on a limb and argue that the hardware of aficionados here is very much skewed towards the higher end (let alone if you consider that those reporting back are yet even a more exclusive club).
Also, even though SK is certainly a must for HDR screenshots, I'd still use steam or whatnot otherwise.

from specialk.

Kaldaien avatar Kaldaien commented on May 21, 2024

This should now be fixed, it was a combination of incorrect memory alignment (D3D9/D3D12 SDR) and SK accidentally invoking its own hooked function (D3D12 HDR).

There are some slight color processing differences that I am working out in DirectXTex. So I don't want to close this thread just yet -- screenshot code's still effectively broken in the sense that SDR screenshots have a slight blue shift versus the Steam overlay or ReShade doing the capture.

from specialk.

marat569 avatar marat569 commented on May 21, 2024

While DX9 is great, 22.7.19 does not work with DX12 SDR or HDR, while the version before it worked for SDR.

3440x1440

from specialk.

Silent-Remux avatar Silent-Remux commented on May 21, 2024

3440x1440 @ 175Hz, Steam overlay on.

As of 22.8.13:

DX9 SDR - broken, no screenshots are taken at all, no click from screenshot sound, nothing in folder. Portal 1 tested.
DX11 SDR - working, Garfield Kart Furious Racing tested.
DX11 SK HDR - working, INSIDE tested.
DX12 SDR - working, RE Village tested.
DX12 SK HDR - working, RE Village tested.

from specialk.

Aemony avatar Aemony commented on May 21, 2024

D3D9 SDR should now work again.

from specialk.

Aemony avatar Aemony commented on May 21, 2024

This was solved a year ago and the issue hasn't cropped up again.

from specialk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.