Comments (1)
I am also supportive of removing a dependency that provides little benefit. I tried to replace uritools
functions with urllib
equivalents and hit some issues though.
While debugging I noticed this:
tools-python/tests/spdx/validation/test_creation_info_validator.py
Lines 31 to 36 in 552940a
And then further noticed that the Python standard libary urllib
module says:
RFC 3986 is considered the current standard and any future changes to
urlparse module should conform with it. The urlparse module is
currently not entirely compliant with this RFC due to defacto
scenarios for parsing, and for backward compatibility purposes, some
parsing quirks from older RFCs are retained. The testcases in
test_urlparse.py provides a good indicator of parsing behavior.
I wonder if urllib
not being compliant with RFC 3986 is why uritools
is used instead of urllib
? Maybe the need for compliance with RFC 3986 is strong enough to merit adding a dependency on uritools
? I personally don't know. But when I tried some simple replacements, it didn't go well :)
from tools-python.
Related Issues (20)
- Incorrect cpe23Type validation? HOT 3
- Relationship with Package Section HOT 2
- Failed to convert spdx to xml with Annotation HOT 1
- Error while calling SPDX parse_file() API inside thread function
- Remove unused semantic_version module HOT 1
- The LicenseRef prefix should not be required for standard licenses HOT 1
- Unhashable type SpdxNoAssertion HOT 2
- Question regarding license_expression_parser behavior HOT 2
- SPDX-tools HOT 1
- duplicate licenseId not detected
- LicenseRef-Case-Sensitive and LicenseRef-case-sensitive not recognized as the same identifier
- OPENSSL and zlib not recognized as valid licences HOT 1
- "primaryPackagePurpose": "application" should be flagged as invalid
- ExternalPackageRefCategory problems HOT 2
- Pipeline is failing for Python 3.7 on MacOS
- invalid homepage url -- potential validation error? HOT 6
- Validation performance extremely poor HOT 5
- url validation fails for gitsm HOT 1
- SPDX License List Version now has Patch version too
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tools-python.