Thoughts on Implementation 1 about spdx-3-serialization-prototype-playground HOT 4 OPEN

@davaya is there a place where these conventions are documented? Do they apply to all serialization formats?

from spdx-3-serialization-prototype-playground.

@davaya My biggest issue with implementation1 is the missing type key which indicates what concrete class to use when converting the serialization back into the model. I'm willing to take that as a deal breaker and move on to implementation 2. Would you mind if I submit some additions to it?

from spdx-3-serialization-prototype-playground.

@davaya is there a place where these conventions are documented? Do they apply to all serialization formats?

Apologies! You have generated the conventions in the model folder here. It doesn't match the current implementation in https://github.com/spdx/tools-python/tree/main/src/spdx_tools/spdx3 which has different names for the ProfileIdentifierType class properties (I'm guessing because it's not python convention to name properties in camelCase unlike other programming languages)

from spdx-3-serialization-prototype-playground.

Ahh - I didn't notice that the tools model was so out of sync with the actual model. I didn't generate the conventions, the spdx-3-model is the "single source of truth", and they changed from UPPERCASE to camelCase vocabularies quite a while ago. ProfileIdentifierType was just created in May, but the diagram was changed from UPPER to camel last December and the tools haven't been keeping up.

There is a PR in Python tools to sync automatically but it hasn't yet been merged.

from spdx-3-serialization-prototype-playground.