Code Monkey home page Code Monkey logo

Comments (6)

simPod avatar simPod commented on May 13, 2024 1

Ah right and I forgot I use this util Response::fromResponseInterface($response). Kk, this makes the most sense #27 (comment) I'll implement it I guess.

from sailor.

spawnia avatar spawnia commented on May 13, 2024

How about we implement something like your example snippet in Spawnia\Sailor\Client\Psr18?

from sailor.

simPod avatar simPod commented on May 13, 2024

yup. that might work as well but what would be the reason to keep the Spawnia\Sailor\Client interface? It already returns PSR response 🤔

from sailor.

spawnia avatar spawnia commented on May 13, 2024

It already returns PSR response 🤔

It returns GraphQL\Sailor\Response.

Here is an example of a client implementation that has nothing to do with PSR-18 or even HTTP: https://github.com/spawnia/sailor/blob/master/src/Client/Log.php
GraphQL itself is transport-agnostic.

from sailor.

spawnia avatar spawnia commented on May 13, 2024

I am happy to accept a merge request for this and would like to keep this issue until something has landed.

from sailor.

spawnia avatar spawnia commented on May 13, 2024

Supported as of https://github.com/spawnia/sailor/releases/tag/v0.9.0

from sailor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.