Allow passing options as env var about phpunit-snapshot-assertions HOT 6 CLOSED

If you want to keep it in cli it can be something like

• SNAPSHOTS_CREATION=false phpunit for avoiding snapshot creation (or WITHOUT_CREATING_SNAPSHOT=true if you prefer)
• SNAPSHOTS_UPDATE=true phpunit to allow snapshot update if already existing.

But with that, we also can set it in .env, in CI env var, in phpunit.xml file, etc. so the users can do whatever they want.

from phpunit-snapshot-assertions.

I did something mildly related in our project:

I learned that when you're developing locally, you really always just want to update the snapshots. You'll see the diff anyway in your favorite VCS. But with a lots-of-devs it's easy to have someone not add this setting into their favourite IDE integration etc. So I extended the trait from this package and implemented my own shouldUpdateSnapshots with some env checking.

And in fact, if the env vars would have been supported already, I could have added this to the shared phpunit.xm.dist for example, not needing to change anything with the package.

I like the idea and too think that env vars are more flexible; the package could just keep the existing behaviour (e.g. command line overrides env var?) and add the new ones.

from phpunit-snapshot-assertions.

I like that users of our package can now simply add something to the command to change certain behaviour. What would the required steps be for a user to run that tests without creating snapshots?

from phpunit-snapshot-assertions.

I would be open for a PR that allows listening for env vars and while still keeping support for the current command line parameters.

from phpunit-snapshot-assertions.

Ok I'm doing it.

Do you have a preference for the env var names ?
CREATE_SNAPSHOTS=false and UPDATE_SNAPSHOTS=true are ok for you?

from phpunit-snapshot-assertions.

We'll continue the conversation in #126

from phpunit-snapshot-assertions.